From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Svante Signell <svante.signell@telia.com>,
Carlos Luna <caralu74@gmail.com>
Subject: Re: [PATCH] x86/PCI: do not tie MSI MS-7253 use_crs quirk to BIOS version
Date: Thu, 1 Mar 2012 10:57:01 -0800 [thread overview]
Message-ID: <20120301105701.62ad4144@jbarnes-desktop> (raw)
In-Reply-To: <20120228213135.GA30986@burratino>
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On Tue, 28 Feb 2012 15:31:35 -0600
Jonathan Nieder <jrnieder@gmail.com> wrote:
> Carlos was getting
>
> WARNING: at drivers/pci/pci.c:118 pci_ioremap_bar+0x24/0x52()
>
> when probing his sound card, and sound did not work. After adding
> pci=use_crs to the kernel command line, no more trouble.
>
> Ok, we can add a quirk. dmidecode output reveals that this is an MSI
> MS-7253, for which we already have a quirk, but the short-sighted
> author tied the quirk to a single BIOS version, making it not kick in
> on Carlos's machine with BIOS V1.2. If a later BIOS update makes it
> no longer necessary to look at the _CRS info it will still be
> harmless, so let's stop trying to guess which versions have and don't
> have accurate _CRS tables.
>
> Addresses https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5533
> Also see <https://bugzilla.kernel.org/show_bug.cgi?id=42619>.
>
> Reported-by: Carlos Luna <caralu74@gmail.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
Applied to my for-linus branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-01 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 18:51 [PATCH] x86/PCI: use host bridge _CRS info on MSI MS-7253 Bjorn Helgaas
2012-02-28 18:55 ` Bjorn Helgaas
2012-02-28 19:09 ` Jesse Barnes
2012-02-28 21:31 ` [PATCH] x86/PCI: do not tie MSI MS-7253 use_crs quirk to BIOS version Jonathan Nieder
2012-02-28 21:35 ` Bjorn Helgaas
2012-03-01 18:57 ` Jesse Barnes [this message]
2012-03-02 4:25 ` Jonathan Nieder
2012-04-09 23:47 ` [3.0.y, 3.2.y, 3.3.y] " Jonathan Nieder
2012-04-09 23:50 ` Jonathan Nieder
2012-04-10 23:00 ` Greg Kroah-Hartman
2012-04-11 1:41 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301105701.62ad4144@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bhelgaas@google.com \
--cc=caralu74@gmail.com \
--cc=jrnieder@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=svante.signell@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox