From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb, PCI: split quirk for usb host controller to three
Date: Thu, 1 Mar 2012 11:03:23 -0800 [thread overview]
Message-ID: <20120301190323.GA5155@xanatos> (raw)
In-Reply-To: <20120301172435.GA8505@kroah.com>
On Thu, Mar 01, 2012 at 09:24:35AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Mar 01, 2012 at 09:17:07AM -0800, Yinghai Lu wrote:
> > so we avoid checking class again and again in that quirk.
> >
> > need to be applied after pci/linux-next and usb/usb-next
>
> As those are two independant trees, this needs to wait until after
> 3.4-rc1 is out.
>
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >
> > ---
> > drivers/usb/host/pci-quirks.c | 42 ++++++++++++++++++++++++++++--------------
> > 1 file changed, 28 insertions(+), 14 deletions(-)
>
> Is this really helping anything here? You added code overall :(
I agree with Greg. Why change this? Does it shave off any boot time?
Please show hard numbers for what improvements this makes. I really
don't want to change PCI init and break people's systems.
Sarah Sharp
next prev parent reply other threads:[~2012-03-01 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 17:17 [RFC PATCH] usb, PCI: split quirk for usb host controller to three Yinghai Lu
2012-03-01 17:24 ` Greg Kroah-Hartman
2012-03-01 17:45 ` Yinghai Lu
2012-03-01 18:20 ` Bjorn Helgaas
2012-03-01 19:20 ` Yinghai Lu
2012-03-01 19:03 ` Sarah Sharp [this message]
2012-03-01 19:19 ` Yinghai Lu
2012-03-01 20:07 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301190323.GA5155@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).