Re: [PATCH] PCI / PM: Disable wakeup during shutdown for devices not enabled to wake up

[Jesse Barnes <jbarnes@virtuousgeek.org>]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Fri, 2 Mar 2012 09:37:12 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > The device driver can monitor .runtime_{suspend / resume} activity
> > and take appropriate action in .shutdown(). Sameer Nanda has sent
> > such a patch (see below). I am not sure this is the adequate fix:
> > 1. the driver ought essentially to perform the hardware part of a
> >    .runtime_resume() on its own behalf. Mildly engaging.
> > 2. by the same line as above, could it make more sense to call
> >    pm_runtime_resume() in driver/base/core.c::device_shutdown ?
> 
> I thought there would be a more elegant way of increasing the device
> use count on entering .shutdown, either from the wifi core or at the
> driver level, so you don't have to track things with a separate flag.
> 
> Rafael?

s/wifi/net of course.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]