From: Jonathan Nieder <jrnieder@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Garrett <mjg@redhat.com>,
bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, stable@vger.kernel.org,
Romain Francoise <romain@orebokech.com>,
Chris Holland <bandidoirlandes@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Hatem Masmoudi <hatem.masmoudi@gmail.com>,
janek <jan0x6c@gmail.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children
Date: Thu, 29 Mar 2012 16:02:33 -0500 [thread overview]
Message-ID: <20120329210233.GD18784@burratino> (raw)
In-Reply-To: <20120329134614.438e8aaf.akpm@linux-foundation.org>
Andrew Morton wrote:
> Jonathan Nieder <jrnieder@gmail.com> wrote:
>> From: Matthew Garrett <mjg@redhat.com>
>> Date: Tue, 27 Mar 2012 10:17:41 -0400
[...]
>> commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking
>> when ASPM is disabled") changed the behaviour of
>> pcie_aspm_sanity_check() to always return 0 if aspm is disabled, in
>> order to avoid cases where we changed ASPM state on pre-PCIe 1.1
>> devices. This skipped the secondary function of
>> pcie_aspm_sanity_check which was to avoid us enabling ASPM on devices
>> that had non-PCIe children, causing trouble later on.
[...]
>> Could
>> you pick it up for linux-next until it makes its way to the PCI tree?
[...]
> Just about the only person who wasn't copied on this email is, umm, the
> PCI maintainer!
Well spotted. Thanks for catching it.
prev parent reply other threads:[~2012-03-29 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 14:17 [PATCH] ASPM: Fix pcie devices with non-pcie children Matthew Garrett
2012-03-27 16:58 ` Colin Ian King
2012-03-28 21:15 ` Jonathan Nieder
2012-03-29 16:32 ` [PATCH resend] " Jonathan Nieder
2012-03-29 20:46 ` Andrew Morton
2012-03-29 20:56 ` Matthew Garrett
2012-03-29 20:59 ` Andrew Morton
2012-03-29 21:49 ` Bjorn Helgaas
2012-03-29 21:02 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329210233.GD18784@burratino \
--to=jrnieder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bandidoirlandes@gmail.com \
--cc=bhelgaas@google.com \
--cc=colin.king@canonical.com \
--cc=hatem.masmoudi@gmail.com \
--cc=jan0x6c@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=romain@orebokech.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).