linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Myron Stowe <myron.stowe@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>, Jiri Kosina <jkosina@suse.cz>,
	Joe Perches <joe@perches.com>,
	"David Howells <dhowells@redhat.com> Jesper Juhl"
	<jj@chaosbits.net>
Subject: Re: [PATCH v2 2/2] arch/tile: tilegx PCI root complex support
Date: Wed, 9 May 2012 19:58:26 +0300	[thread overview]
Message-ID: <20120509165825.GB21461@redhat.com> (raw)
In-Reply-To: <201205091556.q49Fus3V010419@farm-0027.internal.tilera.com>

On Tue, May 08, 2012 at 05:10:17PM -0400, Chris Metcalf wrote:
> +extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);

Please don't put this here. asm-generic/pci_iomap.h already has
a declaration.

-- 
MST

  reply	other threads:[~2012-05-09 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07 20:53 [PATCH 0/3] arch/tile: provide PCIe support for tilegx Chris Metcalf
     [not found] ` <201204072319.q37NJgrI019382@farm-0023.internal.tilera.com>
2012-04-07 21:10 ` [PATCH 3/3] arch/tile: tilegx PCI root complex support Chris Metcalf
2012-04-09 13:59   ` Arnd Bergmann
2012-04-09 21:38     ` Chris Metcalf
2012-04-10  9:14       ` Arnd Bergmann
2012-05-08 20:53         ` [PATCH v2 0/2] arch/tile: " Chris Metcalf
2012-05-08 21:10           ` [PATCH v2 2/2] arch/tile: tilegx " Chris Metcalf
2012-05-09 16:58             ` Michael S. Tsirkin [this message]
2012-04-10  0:01   ` [PATCH 3/3] " Bjorn Helgaas
2012-04-10  9:15     ` Arnd Bergmann
2012-04-15 23:09     ` Chris Metcalf
2012-06-19 19:50   ` Geert Uytterhoeven
2012-06-19 20:07     ` Yinghai Lu
2012-06-19 20:40       ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120509165825.GB21461@redhat.com \
    --to=mst@redhat.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=cmetcalf@tilera.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jj@chaosbits.net \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=myron.stowe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).