linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: joerg.roedel@amd.com, dwmw2@infradead.org,
	iommu@lists.linux-foundation.org
Cc: bhelgaas@google.com, benh@kernel.crashing.org, aik@ozlabs.ru,
	david@gibson.dropbear.id.au, konrad.wilk@oracle.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	gregkh@linuxfoundation.org, ddutile@redhat.com,
	alex.williamson@redhat.com, liuj97@gmail.com
Subject: [PATCH v2 4/7] intel-iommu: Support IOMMU groups
Date: Wed, 30 May 2012 14:19:19 -0600	[thread overview]
Message-ID: <20120530201919.31527.45209.stgit@bling.home> (raw)
In-Reply-To: <20120530201424.31527.33142.stgit@bling.home>

Add IOMMU group support to Intel VT-d code.  This driver sets up
devices ondemand, so make use of the add_device/remove_device
callbacks in IOMMU API to manage setting up the groups.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 drivers/iommu/intel-iommu.c |   43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index c62f2df..4a43452 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -4090,6 +4090,47 @@ static int intel_iommu_domain_has_cap(struct iommu_domain *domain,
 	return 0;
 }
 
+static int intel_iommu_add_device(struct device *dev)
+{
+	struct pci_dev *pdev = to_pci_dev(dev);
+	struct pci_dev *bridge, *dma_pdev;
+	struct iommu_group *group;
+	int ret;
+
+	if (!device_to_iommu(pci_domain_nr(pdev->bus),
+			     pdev->bus->number, pdev->devfn))
+		return -ENODEV;
+
+	bridge = pci_find_upstream_pcie_bridge(pdev);
+	if (bridge) {
+		if (pci_is_pcie(bridge))
+			dma_pdev = pci_get_domain_bus_and_slot(
+						pci_domain_nr(pdev->bus),
+						bridge->subordinate->number, 0);
+		else
+			dma_pdev = pci_dev_get(bridge);
+	} else
+		dma_pdev = pci_dev_get(pdev);
+
+	group = iommu_group_get(&dma_pdev->dev);
+	pci_dev_put(dma_pdev);
+	if (!group) {
+		group = iommu_group_alloc();
+		if (IS_ERR(group))
+			return PTR_ERR(group);
+	}
+
+	ret = iommu_group_add_device(group, dev);
+
+	iommu_group_put(group);
+	return ret;
+}
+
+static void intel_iommu_remove_device(struct device *dev)
+{
+	iommu_group_remove_device(dev);
+}
+
 static struct iommu_ops intel_iommu_ops = {
 	.domain_init	= intel_iommu_domain_init,
 	.domain_destroy = intel_iommu_domain_destroy,
@@ -4099,6 +4140,8 @@ static struct iommu_ops intel_iommu_ops = {
 	.unmap		= intel_iommu_unmap,
 	.iova_to_phys	= intel_iommu_iova_to_phys,
 	.domain_has_cap = intel_iommu_domain_has_cap,
+	.add_device	= intel_iommu_add_device,
+	.remove_device	= intel_iommu_remove_device,
 	.pgsize_bitmap	= INTEL_IOMMU_PGSIZES,
 };
 


  parent reply	other threads:[~2012-05-30 20:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 20:18 [PATCH v2 0/7] IOMMU: Groups support Alex Williamson
2012-05-30 20:18 ` [PATCH v2 1/7] driver core: Add iommu_group tracking to struct device Alex Williamson
2012-06-20  5:45   ` Benjamin Herrenschmidt
2012-05-30 20:18 ` [PATCH v2 2/7] iommu: IOMMU Groups Alex Williamson
2012-06-20 10:01   ` Benjamin Herrenschmidt
2012-06-20 16:48     ` Alex Williamson
2012-06-21  0:07       ` Benjamin Herrenschmidt
2012-05-30 20:19 ` [PATCH v2 3/7] amd_iommu: Support IOMMU groups Alex Williamson
2012-05-30 20:19 ` Alex Williamson [this message]
2012-05-30 20:19 ` [PATCH v2 5/7] amd_iommu: Make use of DMA quirks and ACS checks in " Alex Williamson
2012-05-30 20:19 ` [PATCH v2 6/7] intel-iommu: " Alex Williamson
2012-05-31 19:47   ` Don Dutile
2012-05-31 20:41     ` Alex Williamson
2012-05-30 20:19 ` [PATCH v2 7/7] iommu: Remove group_mf Alex Williamson
2012-06-06 11:05 ` [PATCH v2 0/7] IOMMU: Groups support Joerg Roedel
2012-06-11 15:37   ` Alex Williamson
2012-06-12  2:55     ` Bjorn Helgaas
2012-06-18 17:31     ` Alex Williamson
2012-06-19  9:49       ` Joerg Roedel
2012-06-19 10:40         ` Benjamin Herrenschmidt
2012-06-25 11:29 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120530201919.31527.45209.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ddutile@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joerg.roedel@amd.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liuj97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).