From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from h9.dl5rb.org.uk ([81.2.74.9]:49482 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752042Ab2FORgQ (ORCPT ); Fri, 15 Jun 2012 13:36:16 -0400 Date: Fri, 15 Jun 2012 17:38:23 +0100 From: Ralf Baechle To: Bjorn Helgaas Cc: Myron Stowe , Sebastian Andrzej Siewior , linux-pci@vger.kernel.org, linux-kbuild@vger.kernel.org, Michal Marek Subject: Re: [PATCH 7/9] mips: move PCI fixup hooks from __init to __devinit Message-ID: <20120615163823.GA14302@linux-mips.org> References: <1338749305-22558-1-git-send-email-sebastian@breakpoint.cc> <1338749305-22558-8-git-send-email-sebastian@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Jun 15, 2012 at 10:33:15AM -0600, Bjorn Helgaas wrote: > > Doesn't the above line also need changed to __devinitdata if the > > function itself is being > > changed from __init to __devinit? > > I think so. And pci_irq[] and piixirqmap[] also need to be moved, > since they're referenced by __devinit code. I fixed these, audited > all the other patches, and updated the "next" branch. I'm going to patch that up. Thanks folks, Ralf