From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:51991 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488Ab2GRFD1 (ORCPT ); Wed, 18 Jul 2012 01:03:27 -0400 Received: from /spool/local by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2012 01:03:24 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id B6A5DC90026 for ; Wed, 18 Jul 2012 01:02:35 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6I52Y7I24772738 for ; Wed, 18 Jul 2012 01:02:34 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6I52WLW020521 for ; Wed, 18 Jul 2012 02:02:34 -0300 Date: Wed, 18 Jul 2012 13:02:27 +0800 From: Ram Pai To: Gavin Shan Cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ram Pai , linux-pci@vger.kernel.org, linuxppc-dev@ozlabs.org, yinghai@kernel.org Subject: Re: [PATCH 05/15] pci: resource assignment based on p2p alignment Message-ID: <20120718050227.GC2375@ram-ThinkPad-T61> Reply-To: Ram Pai References: <1342491799-30303-6-git-send-email-shangw@linux.vnet.ibm.com> <20120717050547.GD2369@ram-ThinkPad-T61> <20120717052333.GE2369@ram-ThinkPad-T61> <20120717053648.GA18497@shangw> <20120717055715.GF2369@ram-ThinkPad-T61> <1342516619.3669.5.camel@pasglop> <20120717100314.GB25613@ram-ThinkPad-T61> <1342521498.3669.7.camel@pasglop> <20120718010746.GA4238@shangw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20120718010746.GA4238@shangw> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Jul 18, 2012 at 09:07:46AM +0800, Gavin Shan wrote: > 4. Either "b_res->flags & mask" or "type" to be used for window_alignment(), > I don't think it's big deal because "b_res->flags & mask == type" for > current implementation. However, I'm not sure I still need change it > to "type"? > > min_align = max(min_align, window_alignment(bus, b_res->flags & mask)); Ah. you are right. (b_res->flags & mask) or type, either one is ok. I had a wrong assumption about b_res->flags. I thought it has either IORESOURCE_MEM set or IORESOURCE_PREFETCH set, but not both. Whatever concern I had, i dont have it any more. RP