From: Matthew Garrett <mjg59@srcf.ucam.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: matt.fleming@intel.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com
Subject: Re: [PATCH] Fix priority of non-BAR ROM data
Date: Sun, 29 Jul 2012 22:53:01 +0100 [thread overview]
Message-ID: <20120729215301.GA27358@srcf.ucam.org> (raw)
In-Reply-To: <1343598582.15288.4.camel@shinybook.infradead.org>
On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote:
> + * Some devices may provide ROMs via a source other than the BAR
> + */
> + if (pdev->rom && pdev->romlen) {
> + *size = pdev->romlen;
> + return phys_to_virt(pdev->rom);
Needs casting. My mistake.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-07-29 21:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 16:52 [PATCH V2 1/4] EFI: Stash ROMs if they're not in the PCI BAR Matthew Garrett
2012-07-27 16:52 ` [PATCH V2 2/4] PCI: Add pcibios_add_device Matthew Garrett
2012-07-27 16:52 ` [PATCH V2 3/4] PCI: Add support for non-BAR ROMs Matthew Garrett
2012-07-29 21:49 ` [PATCH] Fix priority of non-BAR ROM data David Woodhouse
2012-07-29 21:53 ` Matthew Garrett [this message]
2012-08-01 14:20 ` Bjorn Helgaas
2012-08-01 14:26 ` Matthew Garrett
2012-07-27 16:52 ` [PATCH V2 4/4] X86: Use PCI setup data Matthew Garrett
2012-07-31 22:32 ` [PATCH V2 1/4] EFI: Stash ROMs if they're not in the PCI BAR Greg KH
2012-08-01 16:54 ` Matthew Garrett
2012-08-01 23:21 ` Greg KH
2012-08-02 4:02 ` Seth Forshee
2012-08-02 10:34 ` Greg KH
2012-08-02 14:57 ` Francois Rigaut
2012-08-02 16:12 ` Seth Forshee
2012-08-02 22:40 ` Francois Rigaut
2012-08-02 22:54 ` Francois Rigaut
2012-08-03 4:53 ` Seth Forshee
[not found] ` <501BD1FC.9020601@mso.anu.edu.au>
[not found] ` <20120803141421.GA8165@thinkpad-t410>
[not found] ` <501C7C1D.5010903@mso.anu.edu.au>
[not found] ` <20120804035844.GA31711@thinkpad-t410>
2012-08-04 5:44 ` Francois Rigaut
2012-08-06 13:49 ` Seth Forshee
2012-08-06 22:50 ` Francois Rigaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729215301.GA27358@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).