From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:34501 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354Ab2G3UJK (ORCPT ); Mon, 30 Jul 2012 16:09:10 -0400 Received: by wgbdr13 with SMTP id dr13so5174369wgb.1 for ; Mon, 30 Jul 2012 13:09:08 -0700 (PDT) Date: Mon, 30 Jul 2012 22:09:05 +0200 From: Jiri Pirko To: Jon Mason Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, Dave Jiang Subject: Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device Message-ID: <20120730200905.GA1673@minipsycho.orion> References: <1343607994-32415-1-git-send-email-jon.mason@intel.com> <1343607994-32415-3-git-send-email-jon.mason@intel.com> <20120730140216.GA1550@minipsycho.orion> <20120730181910.GB987@jonmason-lab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20120730181910.GB987@jonmason-lab> Sender: linux-pci-owner@vger.kernel.org List-ID: Mon, Jul 30, 2012 at 08:19:11PM CEST, jon.mason@intel.com wrote: >On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote: >> Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@intel.com wrote: >> >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev) >> >+{ >> >+ struct net_device *ndev; >> >+ struct ntb_netdev *dev; >> >+ int rc; >> >+ >> >+ ndev = alloc_etherdev(sizeof(struct ntb_netdev)); >> >+ if (!ndev) >> >+ return -ENOMEM; >> >+ >> >+ dev = netdev_priv(ndev); >> >+ dev->ndev = ndev; >> >+ dev->pdev = pdev; >> >+ BUG_ON(!dev->pdev); >> >+ ndev->features = NETIF_F_HIGHDMA; >> >+ >> >+ //ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE; >> ^^ I guess you forgot to un-comment this. > >Oops. An easy fix. Anything else? The rest looks good to me. > >Thanks, >Jon