From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Aug 2012 15:26:16 +0100 From: Matthew Garrett To: Bjorn Helgaas Cc: David Woodhouse , matt.fleming@intel.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] Fix priority of non-BAR ROM data Message-ID: <20120801142616.GA31332@srcf.ucam.org> References: <1343407934-459-1-git-send-email-mjg@redhat.com> <1343407934-459-3-git-send-email-mjg@redhat.com> <1343598582.15288.4.camel@shinybook.infradead.org> <20120729215301.GA27358@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Aug 01, 2012 at 08:20:15AM -0600, Bjorn Helgaas wrote: > On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett wrote: > > On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote: > >> + * Some devices may provide ROMs via a source other than the BAR > >> + */ > >> + if (pdev->rom && pdev->romlen) { > >> + *size = pdev->romlen; > >> + return phys_to_virt(pdev->rom); > > > > Needs casting. My mistake. > > Matthew, are you going to fold this into your patch and repost your > series, or is this a logically separate issue? I can fold it in. -- Matthew Garrett | mjg59@srcf.ucam.org