From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:64734 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343Ab2IQVlp (ORCPT ); Mon, 17 Sep 2012 17:41:45 -0400 Date: Mon, 17 Sep 2012 14:41:36 -0700 From: Tejun Heo To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: rewrite pci_call_probe() to use workqueue instead of work_on_cpu() Message-ID: <20120917214136.GO18677@google.com> References: <20120823213529.GH14962@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Sep 14, 2012 at 12:13:21PM -0600, Bjorn Helgaas wrote: > On Thu, Aug 23, 2012 at 3:35 PM, Tejun Heo wrote: > > pci_call_probe() uses work_on_cpu(), which creates and tears down a > > full kthread on each call, to invoke ->probe() on node local CPU for > > allocation affinity. > > > > The same goal can easily be achieved using a work item. This patch > > rewrites pci_call_probe() so that it uses a work item instead of > > work_on_cpu(). > > > > Note that the function is restructured for simplicity. This adds > > get/put_online_cpus() pair for devices without node but the overhead > > of doing so isn't anything material at this level. > > > > Signed-off-by: Tejun Heo > > I applied this to my "next" branch and pushed it. Thanks! Can you please drop / revert this one? It seems we need work_on_cpu() after all and I'm gonna reimplement it in sane way. Sorry about the trouble. -- tejun