From: Fengguang Wu <fengguang.wu@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [ACPI/PCI] possible recursive locking detected
Date: Sat, 22 Sep 2012 16:10:09 +0800 [thread overview]
Message-ID: <20120922081009.GA5677@localhost> (raw)
In-Reply-To: <CAE9FiQVQMVsqG2vHhyktTtUSJ_dDRpTpwB_x--agMWbm6PHsEg@mail.gmail.com>
On Sat, Sep 22, 2012 at 12:04:51AM -0700, Yinghai Lu wrote:
> On Fri, Sep 21, 2012 at 9:53 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> > On Fri, Sep 21, 2012 at 5:35 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> >> Hi Taku,
> >>
> >> The below oops is pretty reproducible, and shows up first in:
> >>
> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/taku-acpi-pci-host-bridge-v3
> >> head: e3faec8ea9c8aa683c56fa20ff2c58a4c5857960
> >> commit: d3c663236318a43fed5d86a643e6ea2534e9220e [5/7] PCI/ACPI: Protect acpi_pci_roots list with mutex
> >>
> >> [ 8.613239] (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81741e5f>] acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239] (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81741e5f>] acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239] (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81742398>] acpi_pci_register_driver+0x21/0x79
> >> [ 8.613239] lock(acpi_pci_root_lock);
> >> [ 8.613239] lock(acpi_pci_root_lock);
> >> [ 8.613239] #0: (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81742398>] acpi_pci_register_driver+0x21/0x79
> >> [ 8.613239] [<ffffffff81741e5f>] ? acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239] [<ffffffff81741e5f>] ? acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239] [<ffffffff81741e5f>] ? acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239] [<ffffffff81741e5f>] acpi_get_pci_rootbridge_handle+0x22/0x63
> >>
> >> [ 8.610859]
> >> [ 8.611385] =============================================
> >> [ 8.612505] [ INFO: possible recursive locking detected ]
> >> [ 8.613239] 3.6.0-rc1-00022-gd3c6632 #7512 Not tainted
> >> [ 8.613239] ---------------------------------------------
> >> [ 8.613239] swapper/0/1 is trying to acquire lock:
> >> [ 8.613239] (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81741e5f>] acpi_get_pci_rootbridge_handle+0x22/0x63
> >> [ 8.613239]
> >> [ 8.613239] but task is already holding lock:
> >> [ 8.613239] (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81742398>] acpi_pci_register_driver+0x21/0x79
> >> [ 8.613239]
> >> [ 8.613239] other info that might help us debug this:
> >> [ 8.613239] Possible unsafe locking scenario:
> >> [ 8.613239]
> >> [ 8.613239] CPU0
> >> [ 8.613239] ----
> >> [ 8.613239] lock(acpi_pci_root_lock);
> >> [ 8.613239] lock(acpi_pci_root_lock);
> >> [ 8.613239]
> >> [ 8.613239] *** DEADLOCK ***
> >> [ 8.613239]
> >> [ 8.613239] May be due to missing lock nesting notation
> >> [ 8.613239]
> >> [ 8.613239] 1 lock held by swapper/0/1:
> >> [ 8.613239] #0: (acpi_pci_root_lock){+.+.+.}, at: [<ffffffff81742398>] acpi_pci_register_driver+0x21/0x79
> >> [ 8.613239]
> > Please check attached patch that should fix the problem.
>
> updated more aggressive version. two patches.
Yes they work nicely. Thank you very much!
Thanks,
Fengguang
next prev parent reply other threads:[~2012-09-22 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120922003557.GF5959@localhost>
[not found] ` <CAE9FiQVQJQfBZn7AH4M5hibx=iNa9RbfSaBdb35FWxDiRXHvrA@mail.gmail.com>
2012-09-22 7:04 ` [ACPI/PCI] possible recursive locking detected Yinghai Lu
2012-09-22 8:10 ` Fengguang Wu [this message]
2012-09-22 14:11 ` Yinghai Lu
2012-09-24 22:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922081009.GA5677@localhost \
--to=fengguang.wu@intel.com \
--cc=bhelgaas@google.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).