From: Vivek Goyal <vgoyal@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Takao Indoh <indou.takao@jp.fujitsu.com>,
linux-pci@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, martin.wilck@ts.fujitsu.com,
kexec@lists.infradead.org, hbabu@us.ibm.com, mingo@redhat.com,
ishii.hironobu@jp.fujitsu.com, hpa@zytor.com,
bhelgaas@google.com, tglx@linutronix.de
Subject: Re: [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu
Date: Tue, 2 Oct 2012 15:44:29 -0400 [thread overview]
Message-ID: <20121002194429.GG758@redhat.com> (raw)
In-Reply-To: <m2mx04wtpz.fsf@firstfloor.org>
On Tue, Oct 02, 2012 at 12:37:44PM -0700, Andi Kleen wrote:
> Takao Indoh <indou.takao@jp.fujitsu.com> writes:
>
> > These patches reset PCIe devices at boot time to address DMA problem on
> > kdump with iommu. When "reset_devices" is specified, a hot reset is
> > triggered on each PCIe root port and downstream port to reset its
> > downstream endpoint.
>
> Great. I've been pondering this for a long time, but you did finally
> implement it. I hope this will make kdump a lot more reliable at least
> on the systems that support per port reset.
>
> Now the only question is: why make it a option and not default?
Do you mean why to hide it behind "reset_devices" kernel parameter?
One thing still is concerning is how to avoid double resets. We probably
will not want first bus resets and then driver loads and does another
reset after seeing "reset_devices".
Thanks
Vivek
next prev parent reply other threads:[~2012-10-02 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 7:49 [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh
2012-10-02 7:50 ` [PATCH v2 1/2] x86, pci: Reset PCIe devices at boot time Takao Indoh
2012-10-02 7:50 ` [PATCH v2 2/2] x86, pci: Enable PCI INTx when MSI is disabled Takao Indoh
2012-10-02 19:37 ` [PATCH v2 0/2] Reset PCIe devices to address DMA problem on kdump with iommu Andi Kleen
2012-10-02 19:44 ` Vivek Goyal [this message]
2012-10-03 0:57 ` Takao Indoh
2012-10-03 13:23 ` Don Dutile
2012-10-09 9:03 ` Takao Indoh
2012-10-09 16:05 ` Don Dutile
2012-10-10 4:22 ` Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002194429.GG758@redhat.com \
--to=vgoyal@redhat.com \
--cc=andi@firstfloor.org \
--cc=bhelgaas@google.com \
--cc=hbabu@us.ibm.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).