From: Takao Indoh <indou.takao@jp.fujitsu.com>
To: linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org
Cc: tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org,
hbabu@us.ibm.com, andi@firstfloor.org, ddutile@redhat.com,
Takao Indoh <indou.takao@jp.fujitsu.com>,
ishii.hironobu@jp.fujitsu.com, hpa@zytor.com,
bhelgaas@google.com, tglx@linutronix.de, yinghai@kernel.org,
mingo@redhat.com, vgoyal@redhat.com, khalid@gonehiking.org
Subject: [PATCH v6 5/5] x86, pci: Enable PCI INTx when MSI is disabled
Date: Tue, 13 Nov 2012 18:08:32 +0900 (JST) [thread overview]
Message-ID: <20121113090301.1180.93781.sendpatchset@indoh> (raw)
In-Reply-To: <20121113090212.1180.12233.sendpatchset@indoh>
This patch enables INTx if MSI is disabled in pcibios_enable_device().
In normal case interrupt disable bit in command register is 0b on boot
time, but in case of kdump, this bit may be 1b. It causes problems of
some drivers. At leaset I confirmed mptsas driver does not work in such
a case. This patch fix this problem.
Signed-off-by: Takao Indoh <indou.takao@jp.fujitsu.com>
---
arch/x86/pci/common.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index 720e973..2bb7ecc 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -615,8 +615,10 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
if ((err = pci_enable_resources(dev, mask)) < 0)
return err;
- if (!pci_dev_msi_enabled(dev))
+ if (!pci_dev_msi_enabled(dev)) {
+ pci_intx(dev, true);
return pcibios_enable_irq(dev);
+ }
return 0;
}
--
1.7.1
prev parent reply other threads:[~2012-11-13 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 9:07 [PATCH v6 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh
2012-11-13 9:07 ` [PATCH v6 1/5] x86, pci: add dummy pci device for early stage Takao Indoh
2012-11-13 10:01 ` Andrew Murray
2012-11-13 10:57 ` Takao Indoh
2012-11-13 9:07 ` [PATCH v6 2/5] PCI: Define the maximum number of PCI function Takao Indoh
2012-11-13 9:07 ` [PATCH v6 3/5] Make reset_devices available at early stage Takao Indoh
2012-11-13 9:08 ` [PATCH v6 4/5] x86, pci: Reset PCIe devices at boot time Takao Indoh
2012-11-13 9:08 ` Takao Indoh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113090301.1180.93781.sendpatchset@indoh \
--to=indou.takao@jp.fujitsu.com \
--cc=andi@firstfloor.org \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=hpa@zytor.com \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tokunaga.keiich@jp.fujitsu.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).