From: Borislav Petkov <bp@alien8.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Lance Ortiz <lance.ortiz@hp.com>,
bhelgaas@google.com, lance_ortiz@hotmail.com,
jiang.liu@huawei.com, tony.luck@intel.com, rostedt@goodmis.org,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] aerdrv: Trace Event for AER
Date: Sat, 1 Dec 2012 12:43:10 +0100 [thread overview]
Message-ID: <20121201114310.GA7853@liondog.tnic> (raw)
In-Reply-To: <20121201093614.720aa96a@redhat.com>
On Sat, Dec 01, 2012 at 09:36:14AM -0200, Mauro Carvalho Chehab wrote:
> Please don't call it as "ras.h". Call it, instead, ras_aer.h
> (or something similar) as, if we're moving the tracing back to
> include/trace/events/, the same should happen for the memory error
> events.
As you can see yourself, include/trace/events/ contains one header per
topic so having ras_event.h and ras_aer.h or whatever, doesn't fit the
scheme. IOW, we want all RAS-specific tracepoints to be collected in a
header called ras.h like the rest of the subsystems do it. See rcu.h
there for a good example.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-12-01 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 21:33 [PATCH v3 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-11-30 21:33 ` [PATCH v3 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-12-01 15:51 ` Borislav Petkov
2012-12-01 16:01 ` Borislav Petkov
2012-11-30 21:33 ` [PATCH v3 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-12-01 15:56 ` Borislav Petkov
2012-12-01 10:55 ` [PATCH v3 1/3] aerdrv: Trace Event for AER Borislav Petkov
2012-12-01 11:36 ` Mauro Carvalho Chehab
2012-12-01 11:43 ` Borislav Petkov [this message]
2012-12-01 13:28 ` Mauro Carvalho Chehab
2012-12-03 20:01 ` Ortiz, Lance E
2012-12-03 20:27 ` Borislav Petkov
2012-12-03 21:13 ` Ortiz, Lance E
2012-12-03 21:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201114310.GA7853@liondog.tnic \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=lance.ortiz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).