linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: e1000-devel@lists.sourceforge.net, linux-pci@vger.kernel.org,
	Bruce Allan <bruce.w.allan@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [PATCH 1/5] e1000e: fix resuming from runtime-suspend
Date: Fri, 18 Jan 2013 15:42:14 +0400	[thread overview]
Message-ID: <20130118114214.6698.24975.stgit@zurg> (raw)
In-Reply-To: <20130118113019.6698.25941.stgit@zurg>

Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in v2.6.35

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Bruce Allan <bruce.w.allan@intel.com>
---
 drivers/net/ethernet/intel/e1000e/netdev.c |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index fbf75fd..2853c11 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5691,14 +5691,17 @@ static int e1000_runtime_suspend(struct device *dev)
 	struct pci_dev *pdev = to_pci_dev(dev);
 	struct net_device *netdev = pci_get_drvdata(pdev);
 	struct e1000_adapter *adapter = netdev_priv(netdev);
+	int retval;
+	bool wake;
 
-	if (e1000e_pm_ready(adapter)) {
-		bool wake;
+	if (!e1000e_pm_ready(adapter))
+		return 0;
 
-		__e1000_shutdown(pdev, &wake, true);
-	}
+	retval = __e1000_shutdown(pdev, &wake, true);
+	if (!retval)
+		e1000_power_off(pdev, true, wake);
 
-	return 0;
+	return retval;
 }
 
 static int e1000_idle(struct device *dev)


  reply	other threads:[~2013-01-18 11:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 11:42 [PATCH 0/5] pci/e1000e: return runtime-pm back to work Konstantin Khlebnikov
2013-01-18 11:42 ` Konstantin Khlebnikov [this message]
2013-01-28 23:05   ` [PATCH 1/5] e1000e: fix resuming from runtime-suspend Bjorn Helgaas
2013-01-29  1:11     ` Rafael J. Wysocki
2013-01-29  6:32       ` Konstantin Khlebnikov
2013-01-29 12:00         ` Rafael J. Wysocki
2013-01-31  1:18         ` Rafael J. Wysocki
2013-01-31  7:05           ` Konstantin Khlebnikov
2013-01-31  1:23   ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 2/5] e1000e: fix pci device enable counter balance Konstantin Khlebnikov
2013-01-28 23:09   ` Bjorn Helgaas
2013-01-29  0:31     ` Bjorn Helgaas
2013-01-29  6:45       ` Konstantin Khlebnikov
2013-01-31  1:07     ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 3/5] PCI: revert preparing for wakeup in runtime-suspend finalization Konstantin Khlebnikov
2013-01-28 23:17   ` Bjorn Helgaas
2013-01-29  1:15     ` Rafael J. Wysocki
2013-01-29  7:04       ` Konstantin Khlebnikov
2013-01-29 11:55         ` Rafael J. Wysocki
2013-01-31  1:13           ` Rafael J. Wysocki
2013-02-02 12:12             ` Konstantin Khlebnikov
2013-02-02 20:58               ` Rafael J. Wysocki
2013-02-02 22:59                 ` Rafael J. Wysocki
2013-02-03 10:14                   ` Konstantin Khlebnikov
2013-02-03 12:57                     ` Rafael J. Wysocki
2013-02-03 23:03               ` David Airlie
2013-02-03 23:19               ` David Airlie
2013-02-03 23:31                 ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 4/5] PCI: don't touch enable_cnt in pci_device_shutdown() Konstantin Khlebnikov
2013-01-18 16:16   ` Don Dutile
2013-01-28 23:40   ` Bjorn Helgaas
2013-01-28 23:44     ` Bjorn Helgaas
2013-01-29  2:47       ` Khalid Aziz
2013-01-18 11:42 ` [PATCH 5/5] PCI: catch enable-counter underflows Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118114214.6698.24975.stgit@zurg \
    --to=khlebnikov@openvz.org \
    --cc=bruce.w.allan@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).