From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: e1000-devel@lists.sourceforge.net, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 5/5] PCI: catch enable-counter underflows
Date: Fri, 18 Jan 2013 15:42:30 +0400 [thread overview]
Message-ID: <20130118114230.6698.1881.stgit@zurg> (raw)
In-Reply-To: <20130118113019.6698.25941.stgit@zurg>
This patch adds single WARN_ONCE() check for catching 'enable_cnt' imbalances.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 5cb5820..ff93f8f 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1401,6 +1401,9 @@ pci_disable_device(struct pci_dev *dev)
if (dr)
dr->enabled = 0;
+ dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0,
+ "enable counter underflow");
+
if (atomic_sub_return(1, &dev->enable_cnt) != 0)
return;
prev parent reply other threads:[~2013-01-18 11:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 11:42 [PATCH 0/5] pci/e1000e: return runtime-pm back to work Konstantin Khlebnikov
2013-01-18 11:42 ` [PATCH 1/5] e1000e: fix resuming from runtime-suspend Konstantin Khlebnikov
2013-01-28 23:05 ` Bjorn Helgaas
2013-01-29 1:11 ` Rafael J. Wysocki
2013-01-29 6:32 ` Konstantin Khlebnikov
2013-01-29 12:00 ` Rafael J. Wysocki
2013-01-31 1:18 ` Rafael J. Wysocki
2013-01-31 7:05 ` Konstantin Khlebnikov
2013-01-31 1:23 ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 2/5] e1000e: fix pci device enable counter balance Konstantin Khlebnikov
2013-01-28 23:09 ` Bjorn Helgaas
2013-01-29 0:31 ` Bjorn Helgaas
2013-01-29 6:45 ` Konstantin Khlebnikov
2013-01-31 1:07 ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 3/5] PCI: revert preparing for wakeup in runtime-suspend finalization Konstantin Khlebnikov
2013-01-28 23:17 ` Bjorn Helgaas
2013-01-29 1:15 ` Rafael J. Wysocki
2013-01-29 7:04 ` Konstantin Khlebnikov
2013-01-29 11:55 ` Rafael J. Wysocki
2013-01-31 1:13 ` Rafael J. Wysocki
2013-02-02 12:12 ` Konstantin Khlebnikov
2013-02-02 20:58 ` Rafael J. Wysocki
2013-02-02 22:59 ` Rafael J. Wysocki
2013-02-03 10:14 ` Konstantin Khlebnikov
2013-02-03 12:57 ` Rafael J. Wysocki
2013-02-03 23:03 ` David Airlie
2013-02-03 23:19 ` David Airlie
2013-02-03 23:31 ` Rafael J. Wysocki
2013-01-18 11:42 ` [PATCH 4/5] PCI: don't touch enable_cnt in pci_device_shutdown() Konstantin Khlebnikov
2013-01-18 16:16 ` Don Dutile
2013-01-28 23:40 ` Bjorn Helgaas
2013-01-28 23:44 ` Bjorn Helgaas
2013-01-29 2:47 ` Khalid Aziz
2013-01-18 11:42 ` Konstantin Khlebnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118114230.6698.1881.stgit@zurg \
--to=khlebnikov@openvz.org \
--cc=bhelgaas@google.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).