From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:56172 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101Ab3A0Rim (ORCPT ); Sun, 27 Jan 2013 12:38:42 -0500 Date: Sun, 27 Jan 2013 17:38:17 +0000 From: Russell King - ARM Linux To: Yinghai Lu Cc: Bjorn Helgaas , Jiang Liu , "Rafael J. Wysocki" , Taku Izumi , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 16/22] PCI, arm: Kill pci_root_buses Message-ID: <20130127173816.GH23505@n2100.arm.linux.org.uk> References: <1359265003-16166-1-git-send-email-yinghai@kernel.org> <1359265003-16166-17-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1359265003-16166-17-git-send-email-yinghai@kernel.org> Sender: linux-pci-owner@vger.kernel.org List-ID: On Sat, Jan 26, 2013 at 09:36:37PM -0800, Yinghai Lu wrote: > Signed-off-by: Yinghai Lu > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org So... what's this about. This email is all I've recieved, and the only thing that I have to go on is one single subject line and not description about what's going on. I guess there's some other patch introducing this for_each_pci_host_bridge() macro somewhere? I guess that's part of this patch set? Yet... I guess you want an ack for this or something... which would be irresponsible to give without knowing the purpose behind this, the reasoning, or even being able to tell whether the replacement code is functionally equivalent. So, no ack (or nack) at the moment. > --- > arch/arm/kernel/bios32.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c > index 9b72261..d0befe4 100644 > --- a/arch/arm/kernel/bios32.c > +++ b/arch/arm/kernel/bios32.c > @@ -57,13 +57,10 @@ static void pcibios_bus_report_status(struct pci_bus *bus, u_int status_mask, in > > void pcibios_report_status(u_int status_mask, int warn) > { > - struct list_head *l; > + struct pci_host_bridge *host_bridge = NULL; > > - list_for_each(l, &pci_root_buses) { > - struct pci_bus *bus = pci_bus_b(l); > - > - pcibios_bus_report_status(bus, status_mask, warn); > - } > + for_each_pci_host_bridge(host_bridge) > + pcibios_bus_report_status(host_bridge->bus, status_mask, warn); > } > > /* > -- > 1.7.10.4 >