From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([94.23.35.102]:40187 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621Ab3A3NHr (ORCPT ); Wed, 30 Jan 2013 08:07:47 -0500 Date: Wed, 30 Jan 2013 14:07:30 +0100 From: Thomas Petazzoni To: Thierry Reding Cc: Russell King - ARM Linux , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Gregory Clement , Arnd Bergmann , Maen Suleiman , Lior Amsalem , Eran Ben-Avi , Nadav Haklai , Shadi Ammouri , Tawfik Bayouk , Stephen Warren , Jason Gunthorpe Subject: Re: [PATCH v2 19/27] pci: PCIe driver for Marvell Armada 370/XP systems Message-ID: <20130130140730.240b18c1@skate> In-Reply-To: <20130130120344.GA29490@avionic-0098.mockup.avionic-design.de> References: <1359399397-29729-1-git-send-email-thomas.petazzoni@free-electrons.com> <1359399397-29729-20-git-send-email-thomas.petazzoni@free-electrons.com> <20130130113245.GH23505@n2100.arm.linux.org.uk> <20130130120344.GA29490@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: Dear Thierry Reding, On Wed, 30 Jan 2013 13:03:44 +0100, Thierry Reding wrote: > That approach isn't going to work very well with multi-platform, > though, since the function can only be overridden on a > per-architecture basis. I can do like is done for pcibios_align_resource(): put a single implementation of the function in arch/arm/kernel/bios32.c, and make it call a hook registered in the hw_pci structure, or even directly use a numerical value in hw_pci, as Russell suggested earlier. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com