* PME and dependency on ACPI
@ 2013-01-31 14:23 Andrew Murray
2013-01-31 20:59 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Murray @ 2013-01-31 14:23 UTC (permalink / raw)
To: linux-pci; +Cc: bhelgaas, thierry.reding, thomas.petazzoni, rjw, jbarnes
I think that PME may place an unnecessary dependency on ACPI...
in drivers/pci/pcie/Kconfig:
config PCIE_PME
def_bool y
depends on PCIEPORTBUS && PM_RUNTIME && ACPI
and drivers/pci/pcie/pme.c:
#include <linux/acpi.h>
#include <linux/pci-acpi.h>
On an ARM platform I can remove the #include's and remove the Kconfig
dependency on ACPI and PME springs into life.
Is there any other reason why ACPI may be needed here?
Andrew Murray
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PME and dependency on ACPI
2013-01-31 14:23 PME and dependency on ACPI Andrew Murray
@ 2013-01-31 20:59 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2013-01-31 20:59 UTC (permalink / raw)
To: Andrew Murray
Cc: linux-pci, bhelgaas, thierry.reding, thomas.petazzoni, jbarnes
On Thursday, January 31, 2013 02:23:03 PM Andrew Murray wrote:
> I think that PME may place an unnecessary dependency on ACPI...
>
> in drivers/pci/pcie/Kconfig:
>
> config PCIE_PME
> def_bool y
> depends on PCIEPORTBUS && PM_RUNTIME && ACPI
>
>
> and drivers/pci/pcie/pme.c:
>
> #include <linux/acpi.h>
> #include <linux/pci-acpi.h>
>
> On an ARM platform I can remove the #include's and remove the Kconfig
> dependency on ACPI and PME springs into life.
>
> Is there any other reason why ACPI may be needed here?
On x86 (PC) we need ACPI to determine whether or not we're allowed to use the
PME interrupt. In turn, without that iterrupt PME is rather useless.
That said I don't think we need to make the PME *code* depend on ACPI, so it
should be OK to remove the dependency from Kconfig.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-31 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 14:23 PME and dependency on ACPI Andrew Murray
2013-01-31 20:59 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).