From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Mar 2013 14:41:50 -0800 From: Sarah Sharp To: Hannes Reinecke Cc: Bjorn Helgaas , Yinghai Lu , linux-kernel@vger.kernel.org, Frederik Himpe , Oliver Neukum , David Haerdeman , linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, Andy Grover Subject: Re: [PATCH] pci: do not try to assign irq 255 Message-ID: <20130305224150.GE8339@xanatos> References: <1361182193-31894-1-git-send-email-hare@suse.de> <5124820D.2080900@suse.de> <5125C45A.5020208@suse.de> <51305B99.6080806@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <51305B99.6080806@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: > On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: > >[+cc Andy] > > > >3) I don't understand why the xhci init fails in the first place. It > >looks like the "request interrupt 255 failed" message is from > >xhci_try_enable_msi(), but that function tries to enable MSI-X, then > >MSI, then falls back to legacy interrupts, where we get the error. > >But the device supports MSI, so I don't know why we even fall back to > >trying legacy interrupts. Hannes, do you have any insight into that? > >Obviously I'm missing something here. > > > Hehe. Due to overly clever design. > xhci actually sets up interrupts _twice_, once per request_irq() in > the generic code and a second time during xhci_run. > But as the first call fails it'll never ever run the second part. > > I'll be sending a patch. Something like this? http://marc.info/?l=linux-usb&m=132972894117916&w=2 (Apparently we had this issue around the same time last year, but we thought the BIOS bug had been resolved.) Sarah Sharp