From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 8 Mar 2013 15:13:31 -0500 From: Konrad Rzeszutek Wilk To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Bjorn Helgaas , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Andrzej Siewior , Joerg Roedel Subject: Re: [PATCH v2 10/26] x86, irq: Convert irq_2_pin list to generic list Message-ID: <20130308201331.GA21755@phenom.dumpdata.com> References: <1360351703-20571-1-git-send-email-yinghai@kernel.org> <1360351703-20571-11-git-send-email-yinghai@kernel.org> <20130308195055.GD6622@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Mar 08, 2013 at 12:00:43PM -0800, Yinghai Lu wrote: > On Fri, Mar 8, 2013 at 11:50 AM, Konrad Rzeszutek Wilk > wrote: > > On Fri, Feb 08, 2013 at 11:28:07AM -0800, Yinghai Lu wrote: > >> Now irq_2_pin list is own grown list. > > > > I think you meant to say 'has its own list'. Not sure how > > its growing? > > > >> We can use generic list to replace it so we could generic helper > >> functions to operate it. > > > > You need to put the verb a bit earlier. Perhaps: > > > > ".. generic list to replace so that we can operate using > > generic helper functions." > > missed use before generic helper. That would work as well. > > > > >> > >> Also make free_irq_cfg() free irq_2_pin list to support coming ioapic > >> hotplug. > > > > If you have them ready - could you say the titles of the patches here? > > list them all ? No that would not work. Perhaps the first one that introduces the code that uses irq_2_pin ?