From: Andrew Murray <andrew.murray@arm.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/2] PCI: Introduce new MSI chip infrastructure
Date: Fri, 22 Mar 2013 09:37:50 +0000 [thread overview]
Message-ID: <20130322093750.GA679@arm.com> (raw)
In-Reply-To: <1363942307-9327-2-git-send-email-thierry.reding@avionic-design.de>
On Fri, Mar 22, 2013 at 08:51:46AM +0000, Thierry Reding wrote:
> index ce93a34..ea4a5be 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -58,5 +58,15 @@ extern int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
> extern void arch_teardown_msi_irqs(struct pci_dev *dev);
> extern int arch_msi_check_device(struct pci_dev* dev, int nvec, int type);
>
> +struct msi_chip {
> + struct module *owner;
> + struct device *dev;
> +
> + int (*setup_irq)(struct msi_chip *chip, struct pci_dev *dev,
> + struct msi_desc *desc);
> + void (*teardown_irq)(struct msi_chip *chip, unsigned int irq);
> + int (*check_device)(struct msi_chip *chip, struct pci_dev *dev,
> + int nvec, int type);
> +};
Is there a need to add setup_irqs and teardown_irqs functions here? This will
allow your MSI chips to support multiple MSIs per requesting device.
What about restore_msi_irqs? Does this fit in here too?
Andrew Murray
next prev parent reply other threads:[~2013-03-22 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 8:51 [RFC 0/2] PCI: Introduce MSI chip infrastructure Thierry Reding
2013-03-22 8:51 ` [RFC 1/2] PCI: Introduce new " Thierry Reding
2013-03-22 9:37 ` Andrew Murray [this message]
2013-03-22 10:00 ` Thierry Reding
2013-03-22 8:51 ` [RFC 2/2] PCI: tegra: Use " Thierry Reding
2013-03-25 17:01 ` Stephen Warren
2013-03-25 20:02 ` Thierry Reding
2013-03-22 9:30 ` [RFC 0/2] PCI: Introduce " Andrew Murray
2013-03-24 11:06 ` Thomas Petazzoni
2013-03-25 7:58 ` Thierry Reding
2013-03-25 8:38 ` Thomas Petazzoni
2013-03-25 9:15 ` Thierry Reding
2013-03-25 9:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322093750.GA679@arm.com \
--to=andrew.murray@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).