From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Arnd Bergmann <arnd@arndb.de>, Maen Suleiman <maen@marvell.com>,
linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Thierry Reding <thierry.reding@avionic-design.de>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Olof Johansson <olof@lixom.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: Re: [PATCHv9 7/9] pci: PCIe driver for Marvell Armada 370/XP systems
Date: Thu, 16 May 2013 17:49:03 +0200 [thread overview]
Message-ID: <20130516174903.3a7a07ef@skate> (raw)
In-Reply-To: <20130516154031.GF6563@titan.lakedaemon.net>
Dear Jason Cooper,
On Thu, 16 May 2013 11:40:31 -0400, Jason Cooper wrote:
> > > +static int mvebu_pcie_init(void)
> >
> > Building this showed a warning here. It seems you forgot
> > to mark this one as __init.
>
> Thomas, I'll fix this up when I pull this in, no need to resend. :)
I'll resend, because beyond this function pointed by Ezequiel, there
are two other functions that can be marked __init. The one pointed by
Ezequiel is important because it causes a section mismatch
when !CONFIG_MODULES, because in this case platform_driver_probe() is
__init (and this explains what I wasn't seeing the warning, since I'm
building CONFIG_MODULES=y). The two other functions are more cosmetic,
but good to have as well.
It would already been sent if git hadn't decided to do a 'git gc' right
after my rebase. It's been gc-ing for quite some time now...
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-16 15:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 13:25 [PATCHv9 0/9] PCIe support for the Armada 370 and Armada XP SoCs Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 1/9] arm: mvebu: fix the 'ranges' property to handle PCIe Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 2/9] of/pci: Provide support for parsing PCI DT ranges property Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 3/9] of/pci: Add of_pci_get_devfn() function Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 4/9] of/pci: Add of_pci_parse_bus_range() function Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 5/9] clk: mvebu: create parent-child relation for PCIe clocks on Armada 370 Thomas Petazzoni
2013-05-15 21:41 ` Mike Turquette
2013-05-16 7:44 ` Thomas Petazzoni
2013-05-16 8:26 ` Sebastian Hesselbarth
2013-05-16 15:06 ` Jason Cooper
2013-05-17 7:08 ` Mike Turquette
2013-05-17 12:55 ` Jason Cooper
2013-05-15 13:25 ` [PATCHv9 6/9] clk: mvebu: add more PCIe clocks for Armada XP Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 7/9] pci: PCIe driver for Marvell Armada 370/XP systems Thomas Petazzoni
2013-05-16 9:33 ` Ezequiel Garcia
2013-05-16 15:40 ` Jason Cooper
2013-05-16 15:49 ` Thomas Petazzoni [this message]
2013-05-16 15:56 ` Jason Cooper
2013-05-16 16:08 ` Thomas Petazzoni
2013-05-16 16:12 ` Jason Cooper
2013-05-16 20:18 ` Jason Cooper
2013-05-15 13:25 ` [PATCHv9 8/9] arm: mvebu: PCIe support is now available on mvebu Thomas Petazzoni
2013-05-15 13:25 ` [PATCHv9 9/9] arm: mvebu: update defconfig with PCI and USB support Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516174903.3a7a07ef@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=maen@marvell.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=tawfik@marvell.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).