From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@vger.kernel.org>
Received: from mail.free-electrons.com ([94.23.35.102]:60025 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754565Ab3EPPtp (ORCPT
	<rfc822;linux-pci@vger.kernel.org>); Thu, 16 May 2013 11:49:45 -0400
Date: Thu, 16 May 2013 17:49:03 +0200
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
	Arnd Bergmann <arnd@arndb.de>,
	Maen Suleiman <maen@marvell.com>, linux-pci@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Rob Herring <rob.herring@calxeda.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Olof Johansson <olof@lixom.net>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: Re: [PATCHv9 7/9] pci: PCIe driver for Marvell Armada 370/XP
 systems
Message-ID: <20130516174903.3a7a07ef@skate>
In-Reply-To: <20130516154031.GF6563@titan.lakedaemon.net>
References: <1368624323-24311-1-git-send-email-thomas.petazzoni@free-electrons.com>
	<1368624323-24311-8-git-send-email-thomas.petazzoni@free-electrons.com>
	<20130516093312.GB2459@localhost>
	<20130516154031.GF6563@titan.lakedaemon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-pci-owner@vger.kernel.org
List-ID: <linux-pci.vger.kernel.org>

Dear Jason Cooper,

On Thu, 16 May 2013 11:40:31 -0400, Jason Cooper wrote:

> > > +static int mvebu_pcie_init(void)
> > 
> > Building this showed a warning here. It seems you forgot
> > to mark this one as __init.
> 
> Thomas, I'll fix this up when I pull this in, no need to resend. :)

I'll resend, because beyond this function pointed by Ezequiel, there
are two other functions that can be marked __init. The one pointed by
Ezequiel is important because it causes a section mismatch
when !CONFIG_MODULES, because in this case platform_driver_probe() is
__init (and this explains what I wasn't seeing the warning, since I'm
building CONFIG_MODULES=y). The two other functions are more cosmetic,
but good to have as well.

It would already been sent if git hadn't decided to do a 'git gc' right
after my rebase. It's been gc-ing for quite some time now...

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com