From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([94.23.35.102]:49959 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852Ab3E0HMx (ORCPT ); Mon, 27 May 2013 03:12:53 -0400 Date: Mon, 27 May 2013 09:12:49 +0200 From: Thomas Petazzoni To: Wei Yongjun Cc: bhelgaas@google.com, grant.likely@linaro.org, rob.herring@calxeda.com, jason@lakedaemon.net, yongjun_wei@trendmicro.com.cn, linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH -next] pci: mvebu: fix return value check in mvebu_pcie_probe() Message-ID: <20130527091249.52902073@skate> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: Dear Wei Yongjun, On Mon, 27 May 2013 11:38:41 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, function of_clk_get_by_name() returns > ERR_PTR() never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Acked-by: Thomas Petazzoni Jason, this needs to be in the mvebu/pcie branch, so I'll guess you would have to rebase mvebu/pcie_bridge on top of it. Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com