From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Maen Suleiman <maen@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Thierry Reding <thierry.reding@avionic-design.de>
Subject: Re: [PATCHv3 02/11] pci: use weak functions for MSI arch-specific functions
Date: Tue, 25 Jun 2013 11:55:52 +0200 [thread overview]
Message-ID: <20130625115552.7ebdad17@skate> (raw)
In-Reply-To: <CAErSpo6Mm6kYZKN_n-fMRD2T1-F0sf9GStmOTA8tT0wVLedCgw@mail.gmail.com>
Dear Bjorn Helgaas,
On Mon, 24 Jun 2013 19:52:45 -0600, Bjorn Helgaas wrote:
> I agree; the whole point of __weak is to provide a "default"
> implementation, so I hope you can just remove any empty default_*()
> functions and fold the others into the arch_*() functions directly.
>
> If there actually are callbacks from arch-specific strong functions
> back to the stuff in the default_*() functions, that suggests that we
> should refactor and rename that bit of functionality.
There is one such case, as highlighted in the commit log of this patch:
"""
This is needed because the x86 Xen implementation of
teardown_msi_irqs() needs to do some work, and then call the default
implementation of this hook.
"""
Any suggestion on how to solve this particular case?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-06-25 9:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 16:56 [PATCHv3 00/11] MSI support for Marvell EBU PCIe driver Thomas Petazzoni
2013-06-19 16:56 ` [PATCHv3 01/11] irqdomain: add irq_alloc_mapping() function Thomas Petazzoni
2013-06-21 7:19 ` Thomas Petazzoni
2013-06-19 16:56 ` [PATCHv3 02/11] pci: use weak functions for MSI arch-specific functions Thomas Petazzoni
2013-06-20 18:57 ` Thierry Reding
2013-06-21 6:33 ` Thomas Petazzoni
2013-06-25 1:52 ` Bjorn Helgaas
2013-06-25 9:55 ` Thomas Petazzoni [this message]
2013-06-25 16:20 ` Bjorn Helgaas
2013-06-25 16:44 ` Thomas Petazzoni
2013-06-25 16:54 ` Bjorn Helgaas
2013-06-19 16:56 ` [PATCHv3 03/11] PCI: Introduce new MSI chip infrastructure Thomas Petazzoni
2013-06-19 16:56 ` [PATCHv3 04/11] of: pci: add registry of MSI chips Thomas Petazzoni
2013-06-21 7:20 ` Thomas Petazzoni
2013-06-21 10:16 ` Thierry Reding
2013-06-19 16:56 ` [PATCHv3 05/11] irqchip: armada-370-xp: properly request resources Thomas Petazzoni
2013-06-21 7:22 ` Thomas Petazzoni
2013-06-19 16:56 ` [PATCHv3 06/11] irqchip: armada-370-xp: implement MSI support Thomas Petazzoni
2013-06-19 16:56 ` [PATCHv3 07/11] arm: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Thomas Petazzoni
2013-06-21 7:23 ` Thomas Petazzoni
2013-06-21 10:23 ` Thierry Reding
2013-06-19 16:56 ` [PATCHv3 08/11] arm: mvebu: the MPIC now provides MSI controller features Thomas Petazzoni
2013-06-21 10:24 ` Thierry Reding
2013-06-19 16:56 ` [PATCHv3 09/11] pci: mvebu: add support for MSI Thomas Petazzoni
2013-06-21 10:25 ` Thierry Reding
2013-06-25 21:20 ` Bjorn Helgaas
2013-06-19 16:56 ` [PATCHv3 10/11] arm: mvebu: indicate that this platform supports MSI Thomas Petazzoni
2013-06-21 10:28 ` Thierry Reding
2013-06-19 16:56 ` [PATCHv3 11/11] arm: mvebu: link PCIe controllers to the MSI controller Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625115552.7ebdad17@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@avionic-design.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).