From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([94.23.35.102]:41386 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab3FYJzy (ORCPT ); Tue, 25 Jun 2013 05:55:54 -0400 Date: Tue, 25 Jun 2013 11:55:52 +0200 From: Thomas Petazzoni To: Bjorn Helgaas Cc: Thierry Reding , "linux-pci@vger.kernel.org" , Russell King , Grant Likely , Rob Herring , Thomas Gleixner , Jason Cooper , Andrew Lunn , Gregory Clement , Ezequiel Garcia , linux-arm , Maen Suleiman , Lior Amsalem , Thierry Reding Subject: Re: [PATCHv3 02/11] pci: use weak functions for MSI arch-specific functions Message-ID: <20130625115552.7ebdad17@skate> In-Reply-To: References: <1371660979-21588-1-git-send-email-thomas.petazzoni@free-electrons.com> <1371660979-21588-3-git-send-email-thomas.petazzoni@free-electrons.com> <20130620185707.GA8888@mithrandir> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: Dear Bjorn Helgaas, On Mon, 24 Jun 2013 19:52:45 -0600, Bjorn Helgaas wrote: > I agree; the whole point of __weak is to provide a "default" > implementation, so I hope you can just remove any empty default_*() > functions and fold the others into the arch_*() functions directly. > > If there actually are callbacks from arch-specific strong functions > back to the stuff in the default_*() functions, that suggests that we > should refactor and rename that bit of functionality. There is one such case, as highlighted in the commit log of this patch: """ This is needed because the x86 Xen implementation of teardown_msi_irqs() needs to do some work, and then call the default implementation of this hook. """ Any suggestion on how to solve this particular case? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com