linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: linux-pci@vger.kernel.org
Cc: bhelgaas@google.com, indou.takao@jp.fujitsu.com
Subject: [RFC PATCH 0/7] pci: bus and slot reset interfaces
Date: Tue, 30 Jul 2013 21:31:29 -0600	[thread overview]
Message-ID: <20130731031316.31931.56751.stgit@bling.home> (raw)

This series adds PCI bus and slot reset interfaces to the already
existing function reset interface.  I need this for two reasons, the
first is that not all devices support function level reset.  Even
some of those that we detect as supporting a PM reset on D3hot->D0
transition actually don't do any reset.  Others have no reset
capability at all.  We currently implement a secondary bus reset
escalation from the function reset path, but only when there is a
single devfn on the bus.  Drivers like vfio can have ownership of
all of the devices on a bus and should therefore have a path to
initiate a secondary bus reset with multiple devices.  This is
particularly required for use of GPUs by userspace, where none of
the predominant GPUs implement a useful function level reset.

The second reason is that even the current function reset escalating
to a secondary bus reset can cause problems with hotplug controllers.
If a root port supports PCIe HP with suprise removal, a bus reset
can trigger a presence detection change, which results in an attempt
to remove the struct device.  By having a slot reset interface, we
can involve the hotplug controllers to allow for a controlled bus
reset and avoid this spurious removal attempt.

Takao-san also needs a PCI bus reset interface to quiesce devices
during kexec.  I believe this interface also provides that.

Why is this an RFC?  I posted this a while back and self-nacked it
because there were issues when hotplug was built as a module.  Now
that we're removing module support for PCI hotplug and pciehp in
particular, I think that problem is resolved, but it needs further
testing.  Coments welcome.  Thanks,

Alex

---

Alex Williamson (7):
      pci: Create pci_reset_bridge_secondary_bus()
      pci: Add hotplug_slot_ops.reset_slot()
      pci: Implement reset_slot for pciehp
      pci: Add slot reset option to pci_dev_reset
      pci: Split out pci_dev lock/unlock and save/restore
      pci: Add slot and bus reset interfaces
      pci: Wake-up devices before save for reset


 drivers/pci/hotplug/pciehp.h      |    1 
 drivers/pci/hotplug/pciehp_core.c |   12 +
 drivers/pci/hotplug/pciehp_hpc.c  |   31 ++++
 drivers/pci/pci.c                 |  320 ++++++++++++++++++++++++++++++++++---
 include/linux/pci.h               |    3 
 include/linux/pci_hotplug.h       |    4 
 6 files changed, 345 insertions(+), 26 deletions(-)

             reply	other threads:[~2013-07-31  3:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31  3:31 Alex Williamson [this message]
2013-07-31  3:31 ` [RFC PATCH 1/7] pci: Create pci_reset_bridge_secondary_bus() Alex Williamson
2013-07-31  3:31 ` [RFC PATCH 2/7] pci: Add hotplug_slot_ops.reset_slot() Alex Williamson
2013-07-31  3:31 ` [RFC PATCH 3/7] pci: Implement reset_slot for pciehp Alex Williamson
2013-07-31  3:31 ` [RFC PATCH 4/7] pci: Add slot reset option to pci_dev_reset Alex Williamson
2013-07-31  3:32 ` [RFC PATCH 5/7] pci: Split out pci_dev lock/unlock and save/restore Alex Williamson
2013-07-31  3:32 ` [RFC PATCH 6/7] pci: Add slot and bus reset interfaces Alex Williamson
2013-07-31  3:32 ` [RFC PATCH 7/7] pci: Wake-up devices before save for reset Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130731031316.31931.56751.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).