From: Alex Williamson <alex.williamson@redhat.com>
To: bhelgaas@google.com, linux-pci@vger.kernel.org
Cc: alexander.h.duyck@intel.com, ddutile@redhat.com,
indou.takao@jp.fujitsu.com, linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/9] pci: bus and slot reset interfaces
Date: Thu, 08 Aug 2013 14:09:18 -0600 [thread overview]
Message-ID: <20130808200444.2932.17381.stgit@bling.home> (raw)
v5: Increase length of time we assert reset in the final common
secondary bus reset function to 2ms and document that this is
to ensure that reset on the bus is seen for at least a full
1ms (per converstation with Alex Duyck)
Thanks,
Alex
This series adds PCI bus and slot reset interfaces to the already
existing function reset interface. I need this for two reasons, the
first is that not all devices support function level reset. Even
some of those that we detect as supporting a PM reset on D3hot->D0
transition actually don't do any reset. Others have no reset
capability at all. We currently implement a secondary bus reset
escalation from the function reset path, but only when there is a
single devfn on the bus. Drivers like vfio can have ownership of
all of the devices on a bus and should therefore have a path to
initiate a secondary bus reset with multiple devices. This is
particularly required for use of GPUs by userspace, where none of
the predominant GPUs implement a useful function level reset.
The second reason is that even the current function reset escalating
to a secondary bus reset can cause problems with hotplug controllers.
If a root port supports PCIe HP with suprise removal, a bus reset
can trigger a presence detection change, which results in an attempt
to remove the struct device. By having a slot reset interface, we
can involve the hotplug controllers to allow for a controlled bus
reset and avoid this spurious removal attempt.
---
Alex Williamson (9):
pci: Create pci_reset_bridge_secondary_bus()
pci: Add hotplug_slot_ops.reset_slot()
pci: Implement reset_slot for pciehp
pci: Add slot reset option to pci_dev_reset
pci: Split out pci_dev lock/unlock and save/restore
pci: Add slot and bus reset interfaces
pci: Wake-up devices before save for reset
pci: Tune secondary bus reset timing
pci: Remove aer_do_secondary_bus_reset()
drivers/pci/hotplug/pciehp.h | 1
drivers/pci/hotplug/pciehp_core.c | 12 +
drivers/pci/hotplug/pciehp_hpc.c | 31 +++
drivers/pci/pci.c | 349 +++++++++++++++++++++++++++++++++---
drivers/pci/pcie/aer/aerdrv.c | 2
drivers/pci/pcie/aer/aerdrv.h | 1
drivers/pci/pcie/aer/aerdrv_core.c | 35 ----
include/linux/pci.h | 3
include/linux/pci_hotplug.h | 4
9 files changed, 376 insertions(+), 62 deletions(-)
next reply other threads:[~2013-08-08 20:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 20:09 Alex Williamson [this message]
2013-08-08 20:09 ` [PATCH v5 1/9] pci: Create pci_reset_bridge_secondary_bus() Alex Williamson
2013-08-08 20:09 ` [PATCH v5 2/9] pci: Add hotplug_slot_ops.reset_slot() Alex Williamson
2013-08-08 20:09 ` [PATCH v5 3/9] pci: Implement reset_slot for pciehp Alex Williamson
2013-08-08 20:09 ` [PATCH v5 4/9] pci: Add slot reset option to pci_dev_reset Alex Williamson
2013-08-14 21:22 ` Bjorn Helgaas
2013-08-15 23:24 ` rui wang
2013-08-08 20:09 ` [PATCH v5 5/9] pci: Split out pci_dev lock/unlock and save/restore Alex Williamson
2013-08-08 20:09 ` [PATCH v5 6/9] pci: Add slot and bus reset interfaces Alex Williamson
2013-08-14 21:24 ` Bjorn Helgaas
2013-08-14 22:00 ` Alex Williamson
2013-08-08 20:10 ` [PATCH v5 7/9] pci: Wake-up devices before save for reset Alex Williamson
2013-08-08 20:10 ` [PATCH v5 8/9] pci: Tune secondary bus reset timing Alex Williamson
2013-08-08 20:10 ` [PATCH v5 9/9] pci: Remove aer_do_secondary_bus_reset() Alex Williamson
2013-08-15 20:48 ` [PATCH v5 0/9] pci: bus and slot reset interfaces Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808200444.2932.17381.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).