linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: bhelgaas@google.com, linux-pci@vger.kernel.org
Cc: alexander.h.duyck@intel.com, ddutile@redhat.com,
	indou.takao@jp.fujitsu.com, linux-kernel@vger.kernel.org
Subject: [PATCH v5 7/9] pci: Wake-up devices before save for reset
Date: Thu, 08 Aug 2013 14:10:02 -0600	[thread overview]
Message-ID: <20130808201001.2932.66514.stgit@bling.home> (raw)
In-Reply-To: <20130808200444.2932.17381.stgit@bling.home>

Devices come out of reset in D0.  Restoring a device to a different
post-reset state takes more smarts than our simple config space
restore, which can leave devices in an inconsistent state.  For
example, if a device is reset in D3, but the restore doesn't
successfully return the device to D3, then the actual state of the
device and dev->current_state are contradictory.  Put everything
in D0 going into the reset, then we don't need to do anything
special on the way out.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 drivers/pci/pci.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 1dba7dd..b204206 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3332,6 +3332,13 @@ static void pci_dev_unlock(struct pci_dev *dev)
 
 static void pci_dev_save_and_disable(struct pci_dev *dev)
 {
+	/*
+	 * Wake-up device prior to save.  PM registers default to D0 after
+	 * reset and a simple register restore doesn't reliably return
+	 * to a non-D0 state anyway.
+	 */
+	pci_set_power_state(dev, PCI_D0);
+
 	pci_save_state(dev);
 	/*
 	 * Disable the device by clearing the Command register, except for


  parent reply	other threads:[~2013-08-08 20:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 20:09 [PATCH v5 0/9] pci: bus and slot reset interfaces Alex Williamson
2013-08-08 20:09 ` [PATCH v5 1/9] pci: Create pci_reset_bridge_secondary_bus() Alex Williamson
2013-08-08 20:09 ` [PATCH v5 2/9] pci: Add hotplug_slot_ops.reset_slot() Alex Williamson
2013-08-08 20:09 ` [PATCH v5 3/9] pci: Implement reset_slot for pciehp Alex Williamson
2013-08-08 20:09 ` [PATCH v5 4/9] pci: Add slot reset option to pci_dev_reset Alex Williamson
2013-08-14 21:22   ` Bjorn Helgaas
2013-08-15 23:24     ` rui wang
2013-08-08 20:09 ` [PATCH v5 5/9] pci: Split out pci_dev lock/unlock and save/restore Alex Williamson
2013-08-08 20:09 ` [PATCH v5 6/9] pci: Add slot and bus reset interfaces Alex Williamson
2013-08-14 21:24   ` Bjorn Helgaas
2013-08-14 22:00     ` Alex Williamson
2013-08-08 20:10 ` Alex Williamson [this message]
2013-08-08 20:10 ` [PATCH v5 8/9] pci: Tune secondary bus reset timing Alex Williamson
2013-08-08 20:10 ` [PATCH v5 9/9] pci: Remove aer_do_secondary_bus_reset() Alex Williamson
2013-08-15 20:48 ` [PATCH v5 0/9] pci: bus and slot reset interfaces Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130808201001.2932.66514.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=bhelgaas@google.com \
    --cc=ddutile@redhat.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).