From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/3] PCI: Use spec name for the comment of PCIe capability field
Date: Mon, 9 Sep 2013 10:10:59 +0800 [thread overview]
Message-ID: <20130909021059.GB6953@weiyang.vnet.ibm.com> (raw)
In-Reply-To: <20130906231243.GD12956@google.com>
On Fri, Sep 06, 2013 at 05:12:43PM -0600, Bjorn Helgaas wrote:
>On Fri, Sep 06, 2013 at 09:45:57AM +0800, Wei Yang wrote:
>> According to the PCIe specification, bit 7:4 of PCI Express Capabilities
>> Register in a PCI Express Capability Structure is used to identify the
>> Device/Port type. If this field equals to 0x7, this PCIe device is a PCI
>> Express to PCI/PCI-X Bridge. While the comment of this value in the code
>> does not comply with the specification.
>>
>> This patch changes the comment to "PCIE to PCI/PCI-X Bridge" instead of
>> "PCI/PCI-X Bridge", which comply with the specification.
>>
>> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>> ---
>> include/uapi/linux/pci_regs.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
>> index c3cc01d..b82b2ff 100644
>> --- a/include/uapi/linux/pci_regs.h
>> +++ b/include/uapi/linux/pci_regs.h
>> @@ -421,7 +421,7 @@
>> #define PCI_EXP_TYPE_ROOT_PORT 0x4 /* Root Port */
>> #define PCI_EXP_TYPE_UPSTREAM 0x5 /* Upstream Port */
>> #define PCI_EXP_TYPE_DOWNSTREAM 0x6 /* Downstream Port */
>> -#define PCI_EXP_TYPE_PCI_BRIDGE 0x7 /* PCI/PCI-X Bridge */
>> +#define PCI_EXP_TYPE_PCI_BRIDGE 0x7 /* PCIE to PCI/PCI-X Bridge */
>> #define PCI_EXP_TYPE_PCIE_BRIDGE 0x8 /* PCI/PCI-X to PCIE Bridge */
>> #define PCI_EXP_TYPE_RC_END 0x9 /* Root Complex Integrated Endpoint */
>> #define PCI_EXP_TYPE_RC_EC 0xa /* Root Complex Event Collector */
>> --
>> 1.7.1
>>
>
>A similar change is already in Linus' tree:
>
>http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/pci_regs.h?id=fbf501c347b2eea8451a615bd823b6b91a1a8eed
>
>I guess several of us found that comment confusing :)
Thanks, I didn't notice this :-)
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2013-09-09 2:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 1:45 [PATCH 1/3] PCI: use pci_is_root_bus() to check whether it is a root bus Wei Yang
2013-09-06 1:45 ` [PATCH 2/3] PCI: Use spec name for the comment of PCIe capability field Wei Yang
2013-09-06 23:12 ` Bjorn Helgaas
2013-09-09 2:10 ` Wei Yang [this message]
2013-09-06 1:45 ` [PATCH 3/3] PCI: Pass full info for window alignment Wei Yang
2013-09-06 23:19 ` Bjorn Helgaas
2013-09-06 23:09 ` [PATCH 1/3] PCI: use pci_is_root_bus() to check whether it is a root bus Bjorn Helgaas
2013-09-09 2:14 ` Wei Yang
2013-09-09 7:00 ` Wei Yang
2013-09-09 16:15 ` Bjorn Helgaas
2013-09-10 7:46 ` Wei Yang
2013-09-10 10:24 ` Benjamin Herrenschmidt
2013-09-11 0:45 ` Wei Yang
[not found] ` <CA+C+4OYxqgExkepUix5wU4VPRRUcnAFPQJcbUYcLHRcAmNgqgw@mail.gmail.com>
2013-09-09 16:10 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909021059.GB6953@weiyang.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).