From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Bjorn Helgaas' <bhelgaas@google.com>,
linux-pci@vger.kernel.org, 'Jason Cooper' <jason@lakedaemon.net>
Subject: Re: [PATCH 2/3] PCI: mvebu: make local functions static
Date: Thu, 12 Sep 2013 11:37:06 +0200 [thread overview]
Message-ID: <20130912113706.0289df56@skate> (raw)
In-Reply-To: <000401ceaf9b$9132cba0$b39862e0$%han@samsung.com>
Dear Jingoo Han,
On Thu, 12 Sep 2013 18:36:33 +0900, Jingoo Han wrote:
> mvebu_pcie_add_bus(), mvebu_pcie_align_resource() are used only
> in this file. Thus, these local functions should be staticized
> in order to fix the following sparse warnings:
>
> drivers/pci/host/pci-mvebu.c:684:6: warning: symbol
> 'mvebu_pcie_add_bus' was not declared. Should it be static?
> drivers/pci/host/pci-mvebu.c:690:17: warning: symbol
> 'mvebu_pcie_align_resource' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-12 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 9:32 [PATCH 1/3] PCI: tegra: add missing __iomem annotation Jingoo Han
2013-09-12 9:36 ` [PATCH 2/3] PCI: mvebu: make local functions static Jingoo Han
2013-09-12 9:37 ` Thomas Petazzoni [this message]
2013-09-12 9:37 ` [PATCH 3/3] PCI: mvebu: add missing __iomem annotation Jingoo Han
2013-09-16 15:57 ` Thomas Petazzoni
2013-09-17 0:52 ` Jingoo Han
2013-09-17 4:47 ` Thomas Petazzoni
2013-09-19 11:28 ` [PATCH 1/3] PCI: tegra: " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912113706.0289df56@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).