From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sean Cross <xobs@kosagi.com>
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Zhu Richard-R65037 <r65037@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
tharvey@gateworks.com, bhelgaas@google.com
Subject: Re: [PATCH v6 3/3] PCI: imx6: Add support for i.MX6 PCIe controller
Date: Mon, 16 Sep 2013 11:25:01 +0200 [thread overview]
Message-ID: <20130916092501.GY30088@pengutronix.de> (raw)
In-Reply-To: <1379319655-20210-4-git-send-email-xobs@kosagi.com>
On Mon, Sep 16, 2013 at 08:20:54AM +0000, Sean Cross wrote:
> Add support for the PCIe port present on the i.MX6 family of controllers.
> These use the Synopsis Designware core tied to their own PHY.
>
> +static int pcie_phy_poll_ack(void __iomem *dbi_base, int exp_val)
> +{
> + u32 val;
> + u32 max_iterations = 10;
> + u32 wait_counter = 0;
> +
> + do {
> + val = readl(dbi_base + PCIE_PHY_STAT);
> + val = (val >> PCIE_PHY_STAT_ACK_LOC) & 0x1;
> + wait_counter++;
> +
> + if (val == exp_val)
> + return 0;
> +
> + udelay(1);
> + } while ((wait_counter < max_iterations) && (val != exp_val));
The test for val != exp_val is unnecessary now of course.
With this and the devm_clk_get Shawn mentioned:
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-09-16 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 8:20 [PATCH v6 0/3] Add PCIe support for i.MX6q Sean Cross
2013-09-16 8:20 ` [PATCH v6 1/3] ARM: imx: Add LVDS general-purpose clocks to i.MX6Q Sean Cross
2013-09-16 8:20 ` [PATCH v6 2/3] ARM: imx6q: Add PCIe bits to GPR syscon definition Sean Cross
2013-09-16 8:20 ` [PATCH v6 3/3] PCI: imx6: Add support for i.MX6 PCIe controller Sean Cross
2013-09-16 9:25 ` Sascha Hauer [this message]
2013-09-25 16:05 ` Frank Li
2013-09-26 5:54 ` Tim Harvey
2013-09-27 1:38 ` Zhu Richard-R65037
2013-09-27 2:19 ` Shawn Guo
2013-09-27 3:40 ` Jingoo Han
2013-09-27 3:54 ` Sean Cross
2013-09-27 3:52 ` Tim Harvey
2013-10-18 5:32 ` Tim Harvey
2013-10-18 6:34 ` Zhu Richard-R65037
2013-10-18 7:27 ` Tim Harvey
2013-10-18 7:45 ` Zhu Richard-R65037
2013-10-18 15:34 ` Tim Harvey
2013-11-05 17:35 ` Sinan Akman
2013-11-05 20:28 ` Bjorn Helgaas
2013-09-16 9:11 ` [PATCH v6 0/3] Add PCIe support for i.MX6q Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916092501.GY30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=tharvey@gateworks.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).