From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: linux-pci@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: mvebu: Dynamically detect if the PEX link is up to enable hot plug
Date: Tue, 17 Sep 2013 21:50:50 +0200 [thread overview]
Message-ID: <20130917215050.4231c219@skate> (raw)
In-Reply-To: <20130917192412.GB4067@obsidianresearch.com>
Dear Jason Gunthorpe,
On Tue, 17 Sep 2013 13:24:12 -0600, Jason Gunthorpe wrote:
> > I don't have the hardware to test, but this seems to make sense to me.
>
> FWIW, I have tested this on Kirkwood:
>
> mvebu-pcie pex.1: PCI host bridge to bus 0000:00
> pci_bus 0000:00: root bus resource [mem 0xe0000000-0xf0000000]
> pci_bus 0000:00: root bus resource [bus 00-ff]
> pci_bus 0000:00: root bus resource [io 0x1000-0xffff]
> pci 0000:00:01.0: [11ab:7846] type 01 class 0x060400
> PCI: bus0: Fast back to back transfers disabled
> pci 0000:00:01.0: bridge configuration invalid ([bus 00-00]), reconfiguring
> PCI: bus1: Fast back to back transfers enabled
> pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01
> pci 0000:00:01.0: PCI bridge to [bus 01]
> [..]
> Freeing unused kernel memory: 1096K (c02ee000 - c0400000)
>
> .. hot plug the device ..
>
> echo 1 > rescan
>
> pci 0000:01:00.0: [170c:0001] type 00 class 0x058000
> pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x0001ffff]
> pci 0000:01:00.0: PME# supported from D0 D1 D2 D3hot
> pci_bus 0000:01: busn_res: [bus 01] end is updated to 01
> pci 0000:00:01.0: BAR 8: assigned [mem 0xe0000000-0xe00fffff]
> pci 0000:01:00.0: BAR 0: assigned [mem 0xe0000000-0xe001ffff]
> pci 0000:00:01.0: PCI bridge to [bus 01]
> pci 0000:00:01.0: bridge window [mem 0xe0000000-0xe00fffff]
> PCI: enabling device 0000:00:01.0 (0140 -> 0143)
> PCI: enabling device 0000:01:00.0 (0000 -> 0002)
Nice!
Good to see that the changes needed to get PCI hotplug working were not
so large :)
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-09-17 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 18:32 [PATCH] PCI: mvebu: Dynamically detect if the PEX link is up to enable hot plug Jason Gunthorpe
2013-09-17 19:05 ` Thomas Petazzoni
2013-09-17 19:24 ` Jason Gunthorpe
2013-09-17 19:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917215050.4231c219@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).