From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from top.free-electrons.com ([176.31.233.9]:54650 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751944Ab3IWHYr (ORCPT ); Mon, 23 Sep 2013 03:24:47 -0400 Date: Mon, 23 Sep 2013 09:24:41 +0200 From: Thomas Petazzoni To: Jingoo Han Cc: 'Bjorn Helgaas' , linux-pci@vger.kernel.org, 'Jason Cooper' Subject: Re: [PATCH V3 3/3] PCI: mvebu: return NULL instead of ERR_PTR(ret) Message-ID: <20130923092441.18d79397@skate> In-Reply-To: <001001ceb816$5d1aecc0$1750c640$%han@samsung.com> References: <001a01ceb366$5e9481b0$1bbd8510$%han@samsung.com> <001001ceb816$5d1aecc0$1750c640$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: Dear Jingoo Han, On Mon, 23 Sep 2013 13:35:42 +0900, Jingoo Han wrote: > Return NULL instead of ERR_PTR(ret) in order to fix the following > sparse warning: > > drivers/pci/host/pci-mvebu.c:744:31: warning: incorrect type in return expression (different address spaces) > drivers/pci/host/pci-mvebu.c:744:31: expected void [noderef] * > drivers/pci/host/pci-mvebu.c:744:31: got void * > > Signed-off-by: Jingoo Han > Acked-by: Thomas Petazzoni Acked-by: Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com