From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Pratyush Anand' <pratyush.anand@st.com>,
'Bjorn Helgaas' <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
'Thierry Reding' <thierry.reding@gmail.com>,
'Jason Cooper' <jason@lakedaemon.net>,
'Andrew Lunn' <andrew@lunn.ch>,
'Gregory Clement' <gregory.clement@free-electrons.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>,
'Shawn Guo' <shawn.guo@linaro.org>,
'Sean Cross' <xobs@kosagi.com>
Subject: Re: [PATCH] PCI: designware: Make dw_pcie_rd_own_conf(), etc., static
Date: Wed, 9 Oct 2013 11:49:48 +0200 [thread overview]
Message-ID: <20131009114948.397578bf@skate> (raw)
In-Reply-To: <001d01cec48f$8faf2270$af0d6750$%han@samsung.com>
Dear Jingoo Han,
On Wed, 09 Oct 2013 10:33:30 +0900, Jingoo Han wrote:
> ./drivers/pci/host/pci-mvebu.c
> @@ -243,14 +243,7 @@ static int mvebu_pcie_hw_rd_conf(struct mvebu_pcie_port *port,
> writel(PCIE_CONF_ADDR(bus->number, devfn, where),
> port->base + PCIE_CONF_ADDR_OFF);
>
> - *val = readl(port->base + PCIE_CONF_DATA_OFF);
> -
> - if (size == 1)
> - *val = (*val >> (8 * (where & 3))) & 0xff;
> - else if (size == 2)
> - *val = (*val >> (8 * (where & 3))) & 0xffff;
> -
> - return PCIBIOS_SUCCESSFUL;
> + return cfg_read(port->base + PCIE_CONF_DATA_OFF, where, size, val);
> }
The cfg_read() name looks too generic to me to be globally exported in
the kernel, but provided a more specific name is used, I'm fine with
using that in the PCIe mvebu driver.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-09 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:04 [PATCH] PCI: designware: Make dw_pcie_rd_own_conf(), etc., static Bjorn Helgaas
2013-10-08 0:07 ` Bjorn Helgaas
2013-10-08 6:06 ` Pratyush Anand
2013-10-09 1:33 ` Jingoo Han
2013-10-09 9:49 ` Thomas Petazzoni [this message]
2013-10-09 7:50 ` Jingoo Han
2013-10-09 15:00 ` Bjorn Helgaas
2013-10-09 15:19 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009114948.397578bf@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox