* [PATCH] PCI: imx6: increase link startup
@ 2013-10-23 5:12 Tim Harvey
2013-10-23 7:46 ` Shawn Guo
2013-10-29 22:20 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Tim Harvey @ 2013-10-23 5:12 UTC (permalink / raw)
To: linux-pci
Cc: linux-arm-kernel, Marek Vasut, Bjorn Helgaas, Frank Li,
Jingoo Han, Mohit KUMAR, Pratyush Anand, Richard Zhu,
Sascha Hauer, Sean Cross, Shawn Guo, Siva Reddy Kallam,
Srikanth T Shivanand, Troy Kisky, Yinghai Lu
An increase link startup delay is required when certain PCI switches are
attached to the root complex. This was tested with a Pericom switch
and a PLX switch.
From: Marek Vasut <marex@denx.de>
Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/pci/host/pci-imx6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index 90fce05..34c571a 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
while (!dw_pcie_link_up(pp)) {
usleep_range(100, 1000);
count++;
- if (count >= 10) {
+ if (count >= 200) {
dev_err(pp->dev, "phy link never came up\n");
dev_dbg(pp->dev,
"DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: imx6: increase link startup
2013-10-23 5:12 [PATCH] PCI: imx6: increase link startup Tim Harvey
@ 2013-10-23 7:46 ` Shawn Guo
2013-10-29 22:20 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2013-10-23 7:46 UTC (permalink / raw)
To: Tim Harvey
Cc: linux-pci, linux-arm-kernel, Marek Vasut, Bjorn Helgaas, Frank Li,
Jingoo Han, Mohit KUMAR, Pratyush Anand, Richard Zhu,
Sascha Hauer, Sean Cross, Siva Reddy Kallam, Srikanth T Shivanand,
Troy Kisky, Yinghai Lu
On Tue, Oct 22, 2013 at 10:12:18PM -0700, Tim Harvey wrote:
> An increase link startup delay is required when certain PCI switches are
> attached to the root complex. This was tested with a Pericom switch
> and a PLX switch.
>
> From: Marek Vasut <marex@denx.de>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Acked-by: Tim Harvey <tharvey@gateworks.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/pci/host/pci-imx6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index 90fce05..34c571a 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
> while (!dw_pcie_link_up(pp)) {
> usleep_range(100, 1000);
> count++;
> - if (count >= 10) {
> + if (count >= 200) {
> dev_err(pp->dev, "phy link never came up\n");
> dev_dbg(pp->dev,
> "DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: imx6: increase link startup
2013-10-23 5:12 [PATCH] PCI: imx6: increase link startup Tim Harvey
2013-10-23 7:46 ` Shawn Guo
@ 2013-10-29 22:20 ` Bjorn Helgaas
2013-10-30 9:54 ` Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2013-10-29 22:20 UTC (permalink / raw)
To: Tim Harvey
Cc: linux-pci, linux-arm-kernel, Marek Vasut, Frank Li, Jingoo Han,
Mohit KUMAR, Pratyush Anand, Richard Zhu, Sascha Hauer,
Sean Cross, Shawn Guo, Siva Reddy Kallam, Srikanth T Shivanand,
Troy Kisky, Yinghai Lu
On Tue, Oct 22, 2013 at 10:12:18PM -0700, Tim Harvey wrote:
> An increase link startup delay is required when certain PCI switches are
> attached to the root complex. This was tested with a Pericom switch
> and a PLX switch.
>
> From: Marek Vasut <marex@denx.de>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Acked-by: Tim Harvey <tharvey@gateworks.com>
I applied this with Shawn's ack to my pci/host-imx6 branch for v3.13,
thanks!
I assume the intent was that this patch was written by Marek, per the
"From:" line you added above, so I fixed that in the patch so Marek
appears as the author. Let me know if this is incorrect.
> ---
> drivers/pci/host/pci-imx6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index 90fce05..34c571a 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
> while (!dw_pcie_link_up(pp)) {
> usleep_range(100, 1000);
> count++;
> - if (count >= 10) {
> + if (count >= 200) {
> dev_err(pp->dev, "phy link never came up\n");
> dev_dbg(pp->dev,
> "DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: imx6: increase link startup
2013-10-29 22:20 ` Bjorn Helgaas
@ 2013-10-30 9:54 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2013-10-30 9:54 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Tim Harvey, linux-pci, linux-arm-kernel, Frank Li, Jingoo Han,
Mohit KUMAR, Pratyush Anand, Richard Zhu, Sascha Hauer,
Sean Cross, Shawn Guo, Siva Reddy Kallam, Srikanth T Shivanand,
Troy Kisky, Yinghai Lu
Dear Bjorn Helgaas,
> On Tue, Oct 22, 2013 at 10:12:18PM -0700, Tim Harvey wrote:
> > An increase link startup delay is required when certain PCI switches are
> > attached to the root complex. This was tested with a Pericom switch
> > and a PLX switch.
> >
> > From: Marek Vasut <marex@denx.de>
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Acked-by: Tim Harvey <tharvey@gateworks.com>
>
> I applied this with Shawn's ack to my pci/host-imx6 branch for v3.13,
> thanks!
>
> I assume the intent was that this patch was written by Marek, per the
> "From:" line you added above, so I fixed that in the patch so Marek
> appears as the author. Let me know if this is incorrect.
I'm really glad Tim split this patch while I am being totally unhelpful here on
the PCIe front in last few days. Thank you!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-30 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 5:12 [PATCH] PCI: imx6: increase link startup Tim Harvey
2013-10-23 7:46 ` Shawn Guo
2013-10-29 22:20 ` Bjorn Helgaas
2013-10-30 9:54 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).