From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:16174 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752927Ab3J3M6v (ORCPT ); Wed, 30 Oct 2013 08:58:51 -0400 Date: Wed, 30 Oct 2013 15:04:16 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, Bjorn Helgaas , Len Brown , Alex Williamson , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / hotplug / PCI: Always rescan the slot for new devices Message-ID: <20131030130416.GF3521@intel.com> References: <1383136836-15306-1-git-send-email-mika.westerberg@linux.intel.com> <1406112.LRdFoqkugQ@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1406112.LRdFoqkugQ@vostro.rjw.lan> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Oct 30, 2013 at 02:01:40PM +0100, Rafael J. Wysocki wrote: > On Wednesday, October 30, 2013 02:40:36 PM Mika Westerberg wrote: > > Commit 2dc4128 (ACPI / hotplug / PCI: Avoid doing too much for spurious > > notifies) changed the enable_slot() to check return value of pci_scan_slot() > > and if it is zero return early from the function. It means that there were > > no new devices in this particular slot. > > > > However, if a device appeared deeper in the hierarchy the code now ignores > > it causing things like Thunderbolt chaining fail to recognize new devices. > > > > The problem with Alex Williamson's machine was solved with commit > > a47d8c8 (ACPI / hotplug / PCI: Avoid parent bus rescans on spurious device > > checks) and hence we should be able to restore the original functionality > > that we always rescan on bus check notification. > > > > On a device check notification we still check what acpiphp_rescan_slot() > > returns and on zero bail out early. > > > > Signed-off-by: Mika Westerberg > > So, this is a revert of commit a47d8c8, correct? Correct. Plain revert didn't work because the code has changed after that commit.