From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 30 Oct 2013 16:07:33 +0200 From: Mika Westerberg To: Alex Williamson Cc: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Bjorn Helgaas , Len Brown , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / hotplug / PCI: Always rescan the slot for new devices Message-ID: <20131030140733.GH3521@intel.com> References: <1383136836-15306-1-git-send-email-mika.westerberg@linux.intel.com> <1383141466.4097.163.camel@ul30vt.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1383141466.4097.163.camel@ul30vt.home> Sender: linux-acpi-owner@vger.kernel.org List-ID: On Wed, Oct 30, 2013 at 07:57:46AM -0600, Alex Williamson wrote: > On Wed, 2013-10-30 at 14:40 +0200, Mika Westerberg wrote: > > Commit 2dc4128 (ACPI / hotplug / PCI: Avoid doing too much for spurious > > notifies) changed the enable_slot() to check return value of pci_scan_slot() > > and if it is zero return early from the function. It means that there were > > no new devices in this particular slot. > > > > However, if a device appeared deeper in the hierarchy the code now ignores > > it causing things like Thunderbolt chaining fail to recognize new devices. > > > > The problem with Alex Williamson's machine was solved with commit > > a47d8c8 (ACPI / hotplug / PCI: Avoid parent bus rescans on spurious device > > checks) and hence we should be able to restore the original functionality > > that we always rescan on bus check notification. > > > > On a device check notification we still check what acpiphp_rescan_slot() > > returns and on zero bail out early. > > > > Signed-off-by: Mika Westerberg > > --- > > Alex, > > > > Are you able to check if your machine still works and doesn't slow down > > during boot after this patch is applied? > > Looks ok to me, no new console output or boot delay. Thanks, Thanks!