From: Borislav Petkov <bp@alien8.de>
To: Aristeu Rozanski <arozansk@redhat.com>
Cc: linux-edac@vger.kernel.org, tony.luck@intel.com,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Doug Thompson <dougthompson@xmission.com>,
Bjorn Helgaas <bhelgaas@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 01/12] sb_edac: move PCI IDs to pci_ids.h
Date: Wed, 30 Oct 2013 17:40:20 +0100 [thread overview]
Message-ID: <20131030164020.GF13290@pd.tnic> (raw)
In-Reply-To: <1383150426-24730-2-git-send-email-arozansk@redhat.com>
On Wed, Oct 30, 2013 at 12:26:55PM -0400, Aristeu Rozanski wrote:
> According to the comment, it should be done before submitting upstream.
>
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> ---
> drivers/edac/sb_edac.c | 21 ++-------------------
> include/linux/pci_ids.h | 11 +++++++++++
> 2 files changed, 13 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index e04462b..4cdd948 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -57,26 +57,9 @@ static int probed;
> */
>
> /*
> - * FIXME: For now, let's order by device function, as it makes
> - * easier for driver's development process. This table should be
> - * moved to pci_id.h when submitted upstream
Why, is anything else besides sb_edac.c using those?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-10-30 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383150426-24730-1-git-send-email-arozansk@redhat.com>
2013-10-30 16:26 ` [PATCH 01/12] sb_edac: move PCI IDs to pci_ids.h Aristeu Rozanski
2013-10-30 16:40 ` Borislav Petkov [this message]
2013-10-30 17:19 ` Mauro Carvalho Chehab
2013-10-30 17:21 ` Bjorn Helgaas
2013-10-30 20:35 ` Aristeu Rozanski
2013-10-30 20:47 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030164020.GF13290@pd.tnic \
--to=bp@alien8.de \
--cc=arozansk@redhat.com \
--cc=bhelgaas@google.com \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).