From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qe0-f48.google.com ([209.85.128.48]:64960 "EHLO mail-qe0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158Ab3KTQX1 (ORCPT ); Wed, 20 Nov 2013 11:23:27 -0500 Date: Wed, 20 Nov 2013 11:23:24 -0500 From: Tejun Heo To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Michael Ellerman , Benjamin Herrenschmidt , Ben Hutchings , David Laight , Mark Lord , "H. Peter Anvin" , linux-pci@vger.kernel.org Subject: Re: [PATCH RFC v2 11/29] PCI/MSI: Convert pci_msix_table_size() to a public interface Message-ID: <20131120162324.GK28946@htj.dyndns.org> References: <04a7098780907bd8848d4939b24a74e70e274866.1382103786.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <04a7098780907bd8848d4939b24a74e70e274866.1382103786.git.agordeev@redhat.com> Sender: linux-pci-owner@vger.kernel.org List-ID: Hello, On Fri, Oct 18, 2013 at 07:12:11PM +0200, Alexander Gordeev wrote: > Make pci_msix_table_size() return error code if the device > does not support MSI-X. This update is needed to create a > consistent MSI-X counterpart for pci_get_msi_cap() MSI > interface. > > Device drivers can use this interface to obtain maximum number > of MSI-X interrupts the device supports and i.e. use that number > in a following call to pci_enable_msix() interface. Please mention that the return value of the function has been changed in the description. Also, do we want to rename it to pci_get_msix_cap() for consistency? > Signed-off-by: Alexander Gordeev Reviewed-by: Tejun Heo Thanks. -- tejun