From: Pratyush Anand <pratyush.anand@st.com>
To: Marek Vasut <marex@denx.de>
Cc: Tim Harvey <tharvey@gateworks.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>, Frank Li <lznuaa@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
Mohit KUMAR DCG <Mohit.KUMAR@st.com>,
Richard Zhu <r65037@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sean Cross <xobs@kosagi.com>, Shawn Guo <shawn.guo@linaro.org>,
Siva Reddy Kallam <siva.kallam@samsung.com>,
Srikanth T Shivanand <ts.srikanth@samsung.com>,
Troy Kisky <troy.kisky@boundarydevices.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping
Date: Wed, 27 Nov 2013 09:20:56 +0530 [thread overview]
Message-ID: <20131127035056.GA12773@pratyush-vbox> (raw)
In-Reply-To: <201311262146.09780.marex@denx.de>
On Wed, Nov 27, 2013 at 04:46:09AM +0800, Marek Vasut wrote:
> Dear Pratyush Anand,
>
> > Hi,
> >
> > On Wed, Oct 23, 2013 at 12:55:43PM +0800, Tim Harvey wrote:
> > > The IMX6 iATU is used for address translation between the AXI bus
> > > address space and PCI address space. This is used for type0 and type1
> > > config cycles but is not necessary for outbound io/mem regions.
> > >
> > > This patch removes the calls that inappropriately re-configures the ATU
> > > viewport for outbound memory and IO after config cycles and removes them
> > > altogether as they are not necessary.
> > >
> > > This resolves issues with PCI devices behind switches and has been tested
> > > with a Gige device behind a PLX PEX860x switch. More testing is needed
> > > for other configurations.
> >
> > It seems to me that in your controller you have only one view port.
> > Also mem_base and mem_bus_addr is same. Thats why it works in your
> > case.
>
> MX6 has 4 In/4 Out viewports AFAICT.
Then if I do not miss anything, MX6 should work even without this patch.
Regards
Pratyush
>
> Best regards,
> Marek Vasut
next prev parent reply other threads:[~2013-11-27 3:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 4:55 [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping Tim Harvey
2013-10-23 5:04 ` Marek Vasut
2013-10-23 6:40 ` Pratyush Anand
2013-11-26 20:46 ` Marek Vasut
2013-11-27 3:50 ` Pratyush Anand [this message]
2013-11-27 7:42 ` Richard Zhu
2013-11-27 8:24 ` Marek Vasut
2013-11-27 8:36 ` Pratyush Anand
2013-11-27 8:45 ` Marek Vasut
2013-11-28 5:54 ` Jingoo Han
2013-11-29 2:21 ` Marek Vasut
2013-12-03 3:04 ` Richard Zhu
2013-12-03 9:19 ` Marek Vasut
2013-12-04 2:38 ` Richard Zhu
2013-12-04 15:45 ` Marek Vasut
2013-12-05 0:46 ` Richard Zhu
2013-11-25 23:09 ` Bjorn Helgaas
2013-11-26 20:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127035056.GA12773@pratyush-vbox \
--to=pratyush.anand@st.com \
--cc=Mohit.KUMAR@st.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=marex@denx.de \
--cc=r65037@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=siva.kallam@samsung.com \
--cc=tharvey@gateworks.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ts.srikanth@samsung.com \
--cc=xobs@kosagi.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).