From: Thierry Reding <thierry.reding@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Eric Brower <ebrower@nvidia.com>,
linux-pci@vger.kernel.org, swarren@wwwdotorg.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] PCI: Disable Gen2 for Tegra20 and Tegra30
Date: Fri, 29 Nov 2013 16:00:47 +0100 [thread overview]
Message-ID: <20131129150046.GL9712@ulmo.nvidia.com> (raw)
In-Reply-To: <1384815306-3149-1-git-send-email-ebrower@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]
On Mon, Nov 18, 2013 at 02:55:06PM -0800, Eric Brower wrote:
> Tegra20 and Tegra30 do not support gen2 PCIe, so correct the
> register setting to disable it.
>
> Signed-off-by: Eric Brower <ebrower@nvidia.com>
> ---
> drivers/pci/host/pci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index 0afbbbc..b8ba2f7 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -805,7 +805,7 @@ static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
> afi_writel(pcie, value, AFI_PCIE_CONFIG);
>
> value = afi_readl(pcie, AFI_FUSE);
> - value &= ~AFI_FUSE_PCIE_T0_GEN2_DIS;
> + value |= AFI_FUSE_PCIE_T0_GEN2_DIS;
> afi_writel(pcie, value, AFI_FUSE);
>
> /* initialize internal PHY, enable up to 16 PCIE lanes */
Bjorn: can you pick this up directly or would you rather have me prepare
a branch? It's the only one for Tegra so far, so a branch wouldn't be
all that useful. In case you want to pick it up directly:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-29 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 22:55 [PATCH] PCI: Disable Gen2 for Tegra20 and Tegra30 Eric Brower
2013-11-29 15:00 ` Thierry Reding [this message]
2013-12-07 22:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129150046.GL9712@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=ebrower@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).