From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource()
Date: Mon, 2 Dec 2013 09:04:45 +0100 [thread overview]
Message-ID: <201312020904.45124.marex@denx.de> (raw)
In-Reply-To: <1385955575-25270-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When using devm_ioremap_resource(), we do not need to check the return
> value of platform_get_resource(), so just remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/pci/host/pci-imx6.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index bd70af8..5002e23 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
> platform_device *pdev) "imprecise external abort");
>
> dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!dbi_base) {
> - dev_err(&pdev->dev, "dbi_base memory resource not found\n");
> - return -ENODEV;
> - }
> -
> pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
> if (IS_ERR(pp->dbi_base)) {
> ret = PTR_ERR(pp->dbi_base);
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-02 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 3:39 [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Fabio Estevam
2013-12-02 3:39 ` [PATCH 2/2] PCI: imx6: Remove unneeded 'goto err' Fabio Estevam
2013-12-02 8:08 ` Marek Vasut
2013-12-04 18:31 ` Fabio Estevam
2013-12-04 23:49 ` Marek Vasut
2013-12-05 0:10 ` Fabio Estevam
2013-12-09 22:38 ` Bjorn Helgaas
2013-12-10 5:54 ` Jingoo Han
2013-12-10 18:48 ` Marek Vasut
2013-12-02 8:04 ` Marek Vasut [this message]
2013-12-09 21:43 ` [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312020904.45124.marex@denx.de \
--to=marex@denx.de \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).