From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 2/2] PCI: imx6: Remove unneeded 'goto err'
Date: Mon, 2 Dec 2013 09:08:31 +0100 [thread overview]
Message-ID: <201312020908.31316.marex@denx.de> (raw)
In-Reply-To: <1385955575-25270-2-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to use 'goto err' as we can directly return the errors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
I am a bit worried about unwinding of the installation of the DABT hook:
424 /* Added for PCI abort handling */
425 hook_fault_code(16 + 6, imx6q_pcie_abort_handler, SIGBUS, 0,
426 "imprecise external abort");
This is not handled in the fail path. Instead of this patch, would it be
possible for you to fix the failpath to take this part into consideration?
Another option, and I think even a better one, would be to move this DABT
handler installation just before imx6_add_pcie_port() call. You'd still need to
handle it's de-installation in remove(), but you won't have so many functions in
probe() goto-ing to fail path.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-02 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 3:39 [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Fabio Estevam
2013-12-02 3:39 ` [PATCH 2/2] PCI: imx6: Remove unneeded 'goto err' Fabio Estevam
2013-12-02 8:08 ` Marek Vasut [this message]
2013-12-04 18:31 ` Fabio Estevam
2013-12-04 23:49 ` Marek Vasut
2013-12-05 0:10 ` Fabio Estevam
2013-12-09 22:38 ` Bjorn Helgaas
2013-12-10 5:54 ` Jingoo Han
2013-12-10 18:48 ` Marek Vasut
2013-12-02 8:04 ` [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Marek Vasut
2013-12-09 21:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312020908.31316.marex@denx.de \
--to=marex@denx.de \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).