From: Borislav Petkov <bp@alien8.de>
To: Ethan Zhao <ethan.kernel@gmail.com>
Cc: rui wang <ruiv.wang@gmail.com>, Lance Ortiz <lance.ortiz@hp.com>,
Bjorn Helgaas <bhelgaas@google.com>,
lance_ortiz@hotmail.com, jiang.liu@intel.com,
tony.luck@intel.com, rostedt@goodmis.org, mchehab@redhat.com,
linux-acpi@vger.kernel.org, linux-pci <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
gong.chen@intel.com
Subject: Re: [PATCH v10 1/3] aerdrv: Trace Event for AER
Date: Sat, 7 Dec 2013 18:45:42 +0100 [thread overview]
Message-ID: <20131207174542.GB4183@pd.tnic> (raw)
In-Reply-To: <CABawtvPz5sZxhFnQru8Uc6UwF-O8HyGred_RWqBBeT615Qj8sQ@mail.gmail.com>
On Fri, Dec 06, 2013 at 11:11:07PM +0800, Ethan Zhao wrote:
> > @@ -63,10 +63,10 @@ TRACE_EVENT(aer_event,
> >
> > TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
> > __get_str(dev_name),
> > - __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" :
> > - __entry->severity == HW_EVENT_ERR_FATAL ?
> > + __entry->severity == AER_CORRECTABLE ? "Corrected" :
> > + __entry->severity == AER_FATAL ?
> > "Fatal" : "Uncorrected",
>
> Why not "Fatal" : "Non-fatal", ? per the PCIe spec,
> 'Fatal' and 'Non-fatal' are sub-category of "
> Uncorrected". But here "Uncorrected" means "Non-fatal".
... and just to denote that, it'll probably be best to say:
__entry->severity == AER_CORRECTABLE ? "Corrected" :
__entry->severity == AER_FATAL ?
"Fatal" : "Uncorrected, non-fatal"
right?
Btw, Rui, you patch is whitespace-damaged so next time please try
sending from a real mail client which doesn't mangle whitespace and not
from the gmail web interface. Sending the patch to yourself and trying
to apply it is always a good test for that.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-12-07 17:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 23:51 [PATCH v10 1/3] aerdrv: Trace Event for AER Lance Ortiz
2013-01-16 23:51 ` [PATCH v10 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2013-01-16 23:51 ` [PATCH v10 3/3] aerdrv: Cleanup log output for AER Lance Ortiz
2013-01-17 17:21 ` Luck, Tony
2013-12-02 5:05 ` [PATCH v10 1/3] aerdrv: Trace Event " rui wang
2013-12-04 20:38 ` Borislav Petkov
2013-12-06 9:06 ` rui wang
2013-12-06 15:11 ` Ethan Zhao
2013-12-07 17:45 ` Borislav Petkov [this message]
2013-12-04 3:10 ` [BUG] " rui wang
2013-12-04 15:28 ` Ethan Zhao
2013-12-05 18:21 ` Betty Dall
2013-12-05 21:12 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207174542.GB4183@pd.tnic \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=ethan.kernel@gmail.com \
--cc=gong.chen@intel.com \
--cc=jiang.liu@intel.com \
--cc=lance.ortiz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ruiv.wang@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).