From: Jean Delvare <jdelvare@suse.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] PCI/portdrv: Set master earlier
Date: Sun, 8 Dec 2013 14:09:58 +0100 [thread overview]
Message-ID: <20131208140958.0f1eb921@endymion.delvare> (raw)
In-Reply-To: <CAErSpo6ikaTXXvWzX_Z0=mabwD4aedoLoSVjsd+_E5kV9YJpuA@mail.gmail.com>
Hi Bjorn,
On Sat, 7 Dec 2013 15:23:25 -0700, Bjorn Helgaas wrote:
> [+cc Yinghai]
>
> On Wed, Oct 9, 2013 at 8:33 AM, Jean Delvare <jdelvare@suse.de> wrote:
> > Since kernel 3.12-rc3, I get the following warning messages at boot:
> > pcieport 0000:00:07.0: driver skip pci_set_master, fix it!
> > pcieport 0000:00:01.0: driver skip pci_set_master, fix it!
>
> cf3e1feba7f9 ("PCI: Workaround missing pci_set_master in pci drivers")
> added this warning and, at the same time, turned on bus mastering.
>
> There didn't seem to be any reason for the warning and no reason why
> bus mastering should be enabled in the driver rather than the core, so
> fbeeb822f6f4 ("PCI: Drop warning about drivers that don't use
> pci_set_master()") just dropped the warning.
>
> This should resolve the problem, so I don't think there's a need for
> this patch. Let me know if otherwise.
This is fine with me, all I really wanted was to get rid of the
warning. I am not aware of any problem either (but I am no PCI expert
by any means.)
Thanks,
--
Jean Delvare
Suse L3 Support
prev parent reply other threads:[~2013-12-08 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 14:33 [PATCH] PCI/portdrv: Set master earlier Jean Delvare
2013-12-07 22:23 ` Bjorn Helgaas
2013-12-08 3:26 ` Yinghai Lu
2013-12-09 3:07 ` Benjamin Herrenschmidt
2013-12-17 0:53 ` Bjorn Helgaas
2013-12-08 13:09 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131208140958.0f1eb921@endymion.delvare \
--to=jdelvare@suse.de \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).