From: Guenter Roeck <linux@roeck-us.net>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rajat Jain <rajatjain@juniper.net>,
Rajat Jain <rajatjain.linux@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Alex Williamson <alex.williamson@redhat.com>,
Yijing Wang <wangyijing@huawei.com>,
Paul Bolle <pebolle@tiscali.nl>,
Rajat Jain <rajatxjain@gmail.com>,
Guenter Roeck <groeck@juniper.net>
Subject: Re: [PATCH v2 2/4] pciehp: Use link change notifications for hot-plug and removal
Date: Fri, 13 Dec 2013 19:39:11 -0800 [thread overview]
Message-ID: <20131214033911.GA25115@roeck-us.net> (raw)
In-Reply-To: <CAE9FiQX-ZP0R-weuPoOJ6GkPxOLp5jk9thnjfPQ+Q5tCHugD4w@mail.gmail.com>
On Fri, Dec 13, 2013 at 05:58:08PM -0800, Yinghai Lu wrote:
> On Fri, Dec 13, 2013 at 1:14 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > On Fri, Dec 13, 2013 at 12:04 PM, Rajat Jain <rajatjain@juniper.net> wrote:
> >
> >> Once again: the way I interpret this is:
> >> * Always enable Link events.
> >> * Disable presence events if attention button is present.
> >
> > That sounds like a good plan to me.
>
> How about Diag_Reset from MPT2SAS and others?
> link could up and down
>
Good question. Another question is how this would play together
with AER functions, specifically link_reset and slot_reset.
In this context ... is it possible that the link_reset function from struct
pci_error_handlers is never called, or am I missing something ?
Guenter
next prev parent reply other threads:[~2013-12-14 3:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 22:32 [PATCH v2 2/4] pciehp: Use link change notifications for hot-plug and removal Rajat Jain
2013-12-05 9:07 ` Yijing Wang
2013-12-06 3:19 ` Rajat Jain
2013-12-12 22:44 ` Bjorn Helgaas
2013-12-13 6:26 ` Yinghai Lu
2013-12-13 13:21 ` Bjorn Helgaas
2013-12-13 19:04 ` Rajat Jain
2013-12-13 21:14 ` Bjorn Helgaas
2013-12-14 1:58 ` Yinghai Lu
2013-12-14 3:39 ` Guenter Roeck [this message]
2013-12-15 23:24 ` Rajat Jain
2013-12-16 0:18 ` Bjorn Helgaas
2013-12-16 17:39 ` Guenter Roeck
2013-12-17 1:14 ` Bjorn Helgaas
2013-12-17 2:36 ` Guenter Roeck
2013-12-15 22:23 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214033911.GA25115@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=groeck@juniper.net \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rajatjain.linux@gmail.com \
--cc=rajatjain@juniper.net \
--cc=rajatxjain@gmail.com \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).